From 8476e7e3e2abb75c4c7549aefdabdcea0d3c6e6d Mon Sep 17 00:00:00 2001
From: Martin Vladev <martin.vladev@sap.com>
Date: Mon, 18 Mar 2019 12:04:25 +0200
Subject: [PATCH] Update documentation for client-go informers

- `manager.RunnableFunc` should block or it'll trigger shutdown.
- `source.Informer`'s `InformerProvider` field was renamed to `Informer`
---
 docs/book/beyond_basics/using_client_go_informers.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/book/beyond_basics/using_client_go_informers.md b/docs/book/beyond_basics/using_client_go_informers.md
index 7caf75a0971..4745a7ef435 100644
--- a/docs/book/beyond_basics/using_client_go_informers.md
+++ b/docs/book/beyond_basics/using_client_go_informers.md
@@ -24,6 +24,7 @@ generatedInformers := kubeinformers.NewSharedInformerFactory(generatedClient, ti
 
 err := mgr.Add(manager.RunnableFunc(func(s <-chan struct{}) error {
     generatedInformers.Start(s)
+    <- s
     return nil
 }))
 if err != nil {
@@ -50,7 +51,7 @@ The generated InformerFactory must be manually wired into the Controller creatio
 ```go
 // Setup Watch using the client-go generated Informer
 err := ctrl.Watch(
-    &source.Informer{InformerProvider: generatedInformers.Core().V1().Services()},
+    &source.Informer{Informer: generatedInformers.Core().V1().Services()},
     &handler.EnqueueRequestForObject{},
 )
 if err != nil {