From e1f1b5b2644193b7a0bb048a988c1d2e1f86f6bc Mon Sep 17 00:00:00 2001 From: Camila Macedo Date: Mon, 13 Jun 2022 13:33:57 +0100 Subject: [PATCH] :sparkling: adding comment one the scaffolds to warn users about the seccomp spec field usage --- .../v1/scaffolds/internal/templates/config/manager/config.go | 4 ++++ .../v2/scaffolds/internal/templates/config/manager/config.go | 4 ++++ testdata/project-v3-addon/config/manager/manager.yaml | 4 ++++ testdata/project-v3-config/config/manager/manager.yaml | 4 ++++ testdata/project-v3-multigroup/config/manager/manager.yaml | 4 ++++ testdata/project-v3-v1beta1/config/manager/manager.yaml | 4 ++++ .../project-v3-with-kustomize-v2/config/manager/manager.yaml | 4 ++++ testdata/project-v3/config/manager/manager.yaml | 4 ++++ 8 files changed, 32 insertions(+) diff --git a/pkg/plugins/common/kustomize/v1/scaffolds/internal/templates/config/manager/config.go b/pkg/plugins/common/kustomize/v1/scaffolds/internal/templates/config/manager/config.go index 8ff3038cac9..3619c031372 100644 --- a/pkg/plugins/common/kustomize/v1/scaffolds/internal/templates/config/manager/config.go +++ b/pkg/plugins/common/kustomize/v1/scaffolds/internal/templates/config/manager/config.go @@ -72,6 +72,10 @@ spec: spec: securityContext: runAsNonRoot: true + # Note: Do no use the seccompProfile if you are looking for + # to support old Kubernetes versions < 1.19 or distribute + # your solution on vendors versions which are NOT supporting + # this field (i.e. Openshift < 4.11 ). seccompProfile: type: RuntimeDefault containers: diff --git a/pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go b/pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go index 8ff3038cac9..6071dbf029c 100644 --- a/pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go +++ b/pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go @@ -72,6 +72,10 @@ spec: spec: securityContext: runAsNonRoot: true + # Note: Do no use the seccompProfile if you are looking for + # to support old Kubernetes versions < 1.19 or distribute + # your solutions on vendors versions which are not supporting + # it like Openshift versions < 4.11. seccompProfile: type: RuntimeDefault containers: diff --git a/testdata/project-v3-addon/config/manager/manager.yaml b/testdata/project-v3-addon/config/manager/manager.yaml index d857a2f90f7..4270fcb8959 100644 --- a/testdata/project-v3-addon/config/manager/manager.yaml +++ b/testdata/project-v3-addon/config/manager/manager.yaml @@ -26,6 +26,10 @@ spec: spec: securityContext: runAsNonRoot: true + # Note: Do no use the seccompProfile if you are looking for + # to support old Kubernetes versions < 1.19 or distribute + # your solution on vendors versions which are NOT supporting + # this field (i.e. Openshift < 4.11 ). seccompProfile: type: RuntimeDefault containers: diff --git a/testdata/project-v3-config/config/manager/manager.yaml b/testdata/project-v3-config/config/manager/manager.yaml index e6ba8de7902..68a0f3a0bb4 100644 --- a/testdata/project-v3-config/config/manager/manager.yaml +++ b/testdata/project-v3-config/config/manager/manager.yaml @@ -26,6 +26,10 @@ spec: spec: securityContext: runAsNonRoot: true + # Note: Do no use the seccompProfile if you are looking for + # to support old Kubernetes versions < 1.19 or distribute + # your solution on vendors versions which are NOT supporting + # this field (i.e. Openshift < 4.11 ). seccompProfile: type: RuntimeDefault containers: diff --git a/testdata/project-v3-multigroup/config/manager/manager.yaml b/testdata/project-v3-multigroup/config/manager/manager.yaml index d857a2f90f7..4270fcb8959 100644 --- a/testdata/project-v3-multigroup/config/manager/manager.yaml +++ b/testdata/project-v3-multigroup/config/manager/manager.yaml @@ -26,6 +26,10 @@ spec: spec: securityContext: runAsNonRoot: true + # Note: Do no use the seccompProfile if you are looking for + # to support old Kubernetes versions < 1.19 or distribute + # your solution on vendors versions which are NOT supporting + # this field (i.e. Openshift < 4.11 ). seccompProfile: type: RuntimeDefault containers: diff --git a/testdata/project-v3-v1beta1/config/manager/manager.yaml b/testdata/project-v3-v1beta1/config/manager/manager.yaml index d857a2f90f7..4270fcb8959 100644 --- a/testdata/project-v3-v1beta1/config/manager/manager.yaml +++ b/testdata/project-v3-v1beta1/config/manager/manager.yaml @@ -26,6 +26,10 @@ spec: spec: securityContext: runAsNonRoot: true + # Note: Do no use the seccompProfile if you are looking for + # to support old Kubernetes versions < 1.19 or distribute + # your solution on vendors versions which are NOT supporting + # this field (i.e. Openshift < 4.11 ). seccompProfile: type: RuntimeDefault containers: diff --git a/testdata/project-v3-with-kustomize-v2/config/manager/manager.yaml b/testdata/project-v3-with-kustomize-v2/config/manager/manager.yaml index d857a2f90f7..e1d9a7e10c6 100644 --- a/testdata/project-v3-with-kustomize-v2/config/manager/manager.yaml +++ b/testdata/project-v3-with-kustomize-v2/config/manager/manager.yaml @@ -26,6 +26,10 @@ spec: spec: securityContext: runAsNonRoot: true + # Note: Do no use the seccompProfile if you are looking for + # to support old Kubernetes versions < 1.19 or distribute + # your solutions on vendors versions which are not supporting + # it like Openshift versions < 4.11. seccompProfile: type: RuntimeDefault containers: diff --git a/testdata/project-v3/config/manager/manager.yaml b/testdata/project-v3/config/manager/manager.yaml index d857a2f90f7..4270fcb8959 100644 --- a/testdata/project-v3/config/manager/manager.yaml +++ b/testdata/project-v3/config/manager/manager.yaml @@ -26,6 +26,10 @@ spec: spec: securityContext: runAsNonRoot: true + # Note: Do no use the seccompProfile if you are looking for + # to support old Kubernetes versions < 1.19 or distribute + # your solution on vendors versions which are NOT supporting + # this field (i.e. Openshift < 4.11 ). seccompProfile: type: RuntimeDefault containers: