Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unification of receiver names #1182

Closed
Adirio opened this issue Nov 11, 2019 · 2 comments · Fixed by #1186
Closed

Unification of receiver names #1182

Adirio opened this issue Nov 11, 2019 · 2 comments · Fixed by #1186
Assignees
@Adirio
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Adirio
Copy link
Contributor

Adirio commented Nov 11, 2019 •
edited
Loading

Linter message:

Receiver has generic name inspection

Lister description:

Reports receiver names like me, this, self or different from other receiver names for this type.
See Code review comments: receiver names for details.

Umbrella issue: #1176

/kind cleanup
@Adirio Adirio added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 11, 2019
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 11, 2019
This was referenced Nov 11, 2019
Closed
Merged
@camilamacedo86
Copy link
Member

HI, could you please assign the issue to you in order to avoid other dev get it since you gave a PR already one for this one? Also, devs will usually filter for the unassigned ones to know what they can do to contribute with.

PS.: To do it just add a new comment with /assign @your user

@Adirio
Copy link
Contributor Author

Adirio commented Nov 14, 2019

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adirio Adirio

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unification of receiver names Adirio/kubebuilder
3 participants
@Adirio @camilamacedo86 @k8s-ci-robot