Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate CLI completions for bash/zsh #1346

Closed
hasbro17 opened this issue Feb 2, 2020 · 5 comments · Fixed by #1437
Closed

Generate CLI completions for bash/zsh #1346

hasbro17 opened this issue Feb 2, 2020 · 5 comments · Fixed by #1437
Assignees
@bharathi-tenneti
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@hasbro17
Copy link

hasbro17 commented Feb 2, 2020

The Kubebuilder CLI doesn't seem to provide bash or zsh completions similar to kubectl: kubebuilder completion bash
It should be straightforward enough to generate it via the cobra cmd helpers e.g GenBashCompletion().

I can submit a PR to add this in unless there's reasons not to, e.g potentially moving away from cobra CLI in the future, or if any of the incoming plugin and CLI work in #1290 would affect this (which doesn't seem like it would).

/kind feature
@hasbro17 hasbro17 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 2, 2020
@hasbro17
Copy link
Author

hasbro17 commented Feb 2, 2020

/cc @mengqiy

@mengqiy
Copy link
Member

mengqiy commented Feb 3, 2020

It's just because no one has asked for this and we have never prioritized it.
Feel free to submit a PR for bash/zsh completion support.

@hasbro17
Copy link
Author

hasbro17 commented Feb 3, 2020

Yep it's a pretty low priority feature but I've become somewhat used to autocomplete from some of the other CLI tools. I'll submit a PR hopefully soon.

@droot droot added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Feb 5, 2020
@bharathi-tenneti
Copy link
Contributor

/assign

@bharathi-tenneti
Copy link
Contributor

working in this.

@bharathi-tenneti bharathi-tenneti mentioned this issue Mar 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bharathi-tenneti bharathi-tenneti

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bash/zsh completion command bharathi-tenneti/kubebuilder
4 participants
@droot @mengqiy @hasbro17 @bharathi-tenneti