-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove external kustomize dependency #1426
Comments
Kustomize dependency is due to the scaffolded P.S.: modifying the scaffolded |
I see, I didn't know it was used in the Makefile itself (but makes sense). I just took a look at the makefile and why is kustomize not injected like the controller-gen? Perhaps this is a good first step? :) Don't understand why this would break any makefile behavior though |
I couldn't look the links you provided, if you still have access to |
@Adirio all right, please provide me with:
And I'll update the Makefile template to go get kustomize if |
The Makefile template is under |
Hm, can you explain why modifying this will require a major release? As long as the signatures and behaviors stay the same, I don't see the problem?On 11 Mar 2020 21:51, Adrián <notifications@github.com> wrote:
The Makefile template is under pkg/scaffold/internal/templates/v2/makefile.go, but do you need to modify it? If you modify it, then this won't be doable for v2.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.
|
A project initialized ( |
Hm, I see, @Adirio. Note that the old happy path won't change at all (due to the Anyways, if you feel that this is for v3 nonetheless, then we can simply add this issue to the roadmap. |
If the path doesn't change we won't need an update. It was just a comment, do not take it into account, push a PR and we will be able to eval if it needs a major version bump. |
All right, the only path that changes is in case kustomize is not installed in your environment (In this case it will be loaded in). |
This issue should be closed once #1430 (resolves this) merges. |
As kustomize is integrated in kubectl nowadays (without an external dependency), I recommend kubebuilder does the same.
I propose that kustomize becomes an internal go dependency and will provide some documentation here for one of the developers to implement this.
Here is a simple example of using kustomize as a go dependency. Here is the specific line where a resource is generated with the kustomize go library.
As external behavior shouldn't change for this, it can be implemented in v2. Good luck!
The text was updated successfully, but these errors were encountered: