New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Getting started guide missing a prepocessor annotation #1586

Closed

natalefalco opened this issue Jul 5, 2020 · 0 comments · Fixed by #1587

Labels

kind/documentation

Contributor

natalefalco commented Jul 5, 2020

In the documentation there is an example that probably misses an annotation

I expected the snippet to work, but the DeepCopyObject is not created so the make run exits with this error


api/v1/guestbook_types.go:76:25: cannot use &Guestbook literal (type *Guestbook) as type runtime.Object in argument to SchemeBuilder.Register:
	*Guestbook does not implement runtime.Object (missing DeepCopyObject method)

It can be replicated by following the gettting started guide including the optional part

go version go1.14 linux/amd64
kubebuilder version:
- KubeBuilderVersion:"2.3.1",
- KubernetesVendor:"1.16.4",
- GitCommit:"8b53abeb4280186e494b726edf8f54ca7aa64a49"
controller-tools version: ?
kubernetes:
- kubectl: v1.17.0
- server: v1.16.8-eks-e16311

/kind documentation

The text was updated successfully, but these errors were encountered:

k8s-ci-robot added the kind/documentation label

natalefalco mentioned this issue

Add missing kubebuilder annotation to the getting started document #1587

Merged

k8s-ci-robot closed this as completed in #1587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment