Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in multigroup suite_test generation #1665

Closed
antonincms opened this issue Sep 8, 2020 · 3 comments · Fixed by #1673
Closed

Bug in multigroup suite_test generation #1665

antonincms opened this issue Sep 8, 2020 · 3 comments · Fixed by #1673
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@antonincms
Copy link
Contributor

What broke (please include exact error messages if you can):
When generating a basic multigroup project, the generated suite_test.go is wrong and does not register CRD correctly during integration tests.

Step to reproduce:

  • bootstrap the project with kubebuilder init --domain "example.io"
  • modifying the PROJECT file to add multigroup: true
  • creating an API with kubebuilder create api --group webapp --version v1 --kind Guestbook

What did you expect to happen?
The file suite_test.go contains

CRDDirectoryPaths: []string{filepath.Join("..", "config", "crd", "bases")}

where it should contains

CRDDirectoryPaths: []string{filepath.Join("..", "..", "config", "crd", "bases")}

What versions of software are you using?

  • go version : 1.14.6
  • kubebuilder version (kubebuilder version) : Version: version.Version{KubeBuilderVersion:"2.3.1", KubernetesVendor:"1.16.4", GitCommit:"8b53abeb4280186e494b726edf8f54ca7aa64a49", BuildDate:"2020-03-26T16:42:00Z", GoOs:"unknown", GoArch:"unknown"}
  • scaffolding version (check your PROJECT file) : tried 2 and 3-alpha

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 8, 2020
@antonincms antonincms changed the title Multigroup integration test generation Bug in multigroup suite_test generation Sep 8, 2020
@camilamacedo86
Copy link
Member

/assign @camilamacedo86

@theishshah
Copy link
Contributor

/assign @theishshah

@camilamacedo86
Copy link
Member

camilamacedo86 commented Oct 19, 2020

The solution of this issue was made in the PRs: #1673 and #1682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants