Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot/release cloudbuild config is b0rked #1694

Closed
DirectXMan12 opened this issue Sep 24, 2020 · 6 comments · Fixed by #1853
Closed

snapshot/release cloudbuild config is b0rked #1694

DirectXMan12 opened this issue Sep 24, 2020 · 6 comments · Fixed by #1853
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@DirectXMan12
Copy link
Contributor

The cloudbuild configs in build/cloudbuild.yaml & build/cloudbuild_snapshot.yaml are b0rked -- they use Go 1.12 to build, and we've long since required Go 1.13. We should fix them up.

While we're at it, they seem to still be using go-releaser, which I think we wanted to switch off of. We should start populating kubernetes-sigs/kubebuilder-release-tools with common releasing infrastructure, and maybe consider moving over to that where possible

cc @vincepri who I think had some ideas around this

@DirectXMan12 DirectXMan12 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 24, 2020
@vincepri
Copy link
Member

Does this affect the ability for us to release new kubebuilder-tools for testenv? Or is this separate?

@DirectXMan12
Copy link
Contributor Author

separate -- we've got 4 cloudbuild triggers currently:

  • (tools-releases:build/cloudbuild_tools.yaml) on push to release-tools --> build darwin/amd64 envtest bundle --> upload to GCR
  • (tools-releases:build/cloudbuild_tools.yaml) on push to release-tools --> build linux/amd64 envtest bundle --> upload to GCR
  • (master:build/cloudbuild.yaml) on tag to master --> build linux/amd64, darwin/amd64 kubebuilder executable --> upload to GitHub release
  • (master:build/cloudbuild_snapshot.yaml) on push to master --> build linux/amd64, darwin/amd64 kubebuilder executable --> upload to snapshots GCS bucket

@DirectXMan12
Copy link
Contributor Author

the ones that are broken are the last two, although the tag one hasn't manifested since we haven't done a release in a while

@vincepri
Copy link
Member

got it, thanks for the info 🤔, have to take a deeper look

@camilamacedo86
Copy link
Member

Hi @vincepri and @DirectXMan12,

they use Go 1.12 to build, and we've long since required Go 1.13.

Might valid consider using Go 1.15. See that controller-runtime is already updated and we have an open to do it here as well. see; #1716

@DirectXMan12
Copy link
Contributor Author

👍

@camilamacedo86 camilamacedo86 added this to the v3.0.0 milestone Oct 20, 2020
@camilamacedo86 camilamacedo86 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants