Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffolding for webhook tests #1707

Closed
ymmt2005 opened this issue Oct 4, 2020 · 1 comment · Fixed by #1710
Closed

Scaffolding for webhook tests #1707

ymmt2005 opened this issue Oct 4, 2020 · 1 comment · Fixed by #1710
Assignees
@prafull01
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v3.0.0

Comments

@ymmt2005
Copy link

ymmt2005 commented Oct 4, 2020

controller-runtime/pkg/envtest has built-in support for webhook test.
It would be great if kubebuilder can generate a test runner under api/ directory because it already can scaffold webhooks.

I have a good example of such a test runner.
https://github.com/cybozu-go/coil/blob/master/v2/api/v2/suite_test.go

/kind feature
@ymmt2005 ymmt2005 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 4, 2020
@prafull01
Copy link
Contributor

/assign

@prafull01 prafull01 mentioned this issue Oct 6, 2020
Merged
@camilamacedo86 camilamacedo86 added this to the v3-alpha milestone Oct 11, 2020
@camilamacedo86 camilamacedo86 modified the milestones: v3+ plugin, v3.0.0 Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prafull01 prafull01

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

✨ Add scaffolding for the webhook test suite (go/v3-alpha) prafull01/kubebuilder
3 participants
@ymmt2005 @camilamacedo86 @prafull01