Improvements in suite_test.go files generated by kubebuilder (v3+ only)

[prafull01]

From the discussion happened on the 1710 [comment] ,the following improvements should happen on the suite_test.go files generated by kubebuilder:

1. Instead of mutating same error every time, use the form foo, err := Func()
2. Remove Done from the BeforeSuite as we are not running the BeforeSuite asynchronously.

/kind feature

[camilamacedo86]

Just to register, these suggestions came from the community and were made in the review of #1710 (https://github.com/kubernetes-sigs/kubebuilder/pull/1710/files#r508884888 and https://github.com/kubernetes-sigs/kubebuilder/pull/1710/files#r508885222 ).

So, shows that make more sense to address the suggestions in a follow up of #1710 in both suite_test.go files. (for webhooks controllers) and only for v3+.

[prafull01]

/assign

[ndipebot]

• +1 for switching to foo, err := Func() in scaffolding for both controller and webhook.

• Tested eliminating Done from BeforeSuite in my controller and webhook integration tests and everything runs smoothly.