Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Export scaffolding machinery #2036

Closed
Adirio opened this issue Feb 23, 2021 · 3 comments · Fixed by #2082
Closed

✨ Export scaffolding machinery #2036

Adirio opened this issue Feb 23, 2021 · 3 comments · Fixed by #2082
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
3.*

Comments

@Adirio
Copy link
Contributor

Adirio commented Feb 23, 2021

The scaffolding machinery is not being exported as it is placed in an internal directory (from older kubebuilder versions when it was not designed to be a library. We should probably move this package outside of internal so that it can be used by third-party developers.

As an example, operator SDK is copying this folder.

/kind feature
@Adirio Adirio added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 23, 2021
@Adirio Adirio mentioned this issue Feb 23, 2021
Closed
@camilamacedo86
Copy link
Member

+1 for me.

@camilamacedo86 camilamacedo86 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 23, 2021
@camilamacedo86 camilamacedo86 added this to the 3.1.0 milestone Feb 23, 2021
@camilamacedo86
Copy link
Member

@Adirio will also check if nobody has any objections to it before move forward ( controller-tools meeting and @DirectXMan12 )

@DirectXMan12
Copy link
Contributor

Seems like the public part of these interfaces is fairly minimal, so it seems pretty reasonable to expose these without them being restrictive to internal refactor.

This was referenced Mar 3, 2021
Closed
Closed
Merged
@camilamacedo86 camilamacedo86 modified the milestones: 3.1.0, 3.2.0 Mar 6, 2021
This was referenced Mar 9, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
3.*
3 participants
@DirectXMan12 @Adirio @camilamacedo86