Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert WithCompletion into a cli.Option #2044

Closed
Adirio opened this issue Feb 26, 2021 · 0 comments · Fixed by #2045
Closed

Convert WithCompletion into a cli.Option #2044

Adirio opened this issue Feb 26, 2021 · 0 comments · Fixed by #2045
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Adirio
Copy link
Contributor

Adirio commented Feb 26, 2021

While WithCompletion is technically an Option, it doesn't reflect that in its signature.

This is reflected in the library documentation, where WithCompletion is not listed under the Option type.
@Adirio Adirio added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 26, 2021
This was referenced Feb 26, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚠️ Explicitly define WithCompletion as an Option Adirio/kubebuilder
1 participant
@Adirio