Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Config interface for v3.0.0 #2046

Closed
Adirio opened this issue Feb 26, 2021 · 0 comments · Fixed by #2047
Closed

Final Config interface for v3.0.0 #2046

Adirio opened this issue Feb 26, 2021 · 0 comments · Fixed by #2047

Comments

@Adirio
Copy link
Contributor

Adirio commented Feb 26, 2021

The Config interface has 2 methods that seem a bit out of place.
IsCRDVersionCompatible and IsWebhookVersionCompatible encode inside a project configuration version the possibility of having only one or multiple different CRD/webhook versions. While this check is needed as we are not supporting multiple CRD/webhook versions, the project configuration itself is not th elimiting factor. A better API design would be replacing these two methods by ListCRDVersions() []string and ListWebhookVersions() []string letting the plugins be the ones that check if they are valid. This would allow a future plugin go/v4 accept multiple CRD versions in a single project but still use project version 3.

/remove-kind feature

@Adirio Adirio added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 26, 2021
@k8s-ci-robot k8s-ci-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants