Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: extra commands require a valid PROJECT file again #2125

Closed
jmrodri opened this issue Apr 5, 2021 · 2 comments · Fixed by #2126
Closed

Regression: extra commands require a valid PROJECT file again #2125

jmrodri opened this issue Apr 5, 2021 · 2 comments · Fixed by #2126
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@jmrodri
Copy link
Contributor

jmrodri commented Apr 5, 2021

https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/cli/cli.go#L194 returns an error when it can not parse the config file. This means that extra commands will no longer work. This affects the operator-sdk because we have a command alpha config-3alpha-to-3 that will convert 3alpha PROJECT config to valid 3 config. But the error prevents this command from ever running.

Similarly, version also no longer works if we can't parse the PROJECT config file which is a regression.

What versions of software are you using? Specifically, the following are often useful:

  • go version
  • kubebuilder version (kubebuilder version) and scaffolding version (check your PROJECT file): *v3.0.0-beta.1`
  • controller-runtime version (check your go.mod file)
  • controller-tools version
  • Kubernetes & kubectl versions (just run kubectl version against your API server)

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 5, 2021
@jmrodri
Copy link
Contributor Author

jmrodri commented Apr 5, 2021

/assign @jmrodri

@Adirio
Copy link
Contributor

Adirio commented Apr 6, 2021

I would not consider this a regression as the previous case was when the config file didn't exist.

@camilamacedo86 camilamacedo86 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 6, 2021
@camilamacedo86 camilamacedo86 added this to the v3.0.0 milestone Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants