Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize kubebuilder codegeneration labels to have +kubebuilder: prefix #22

Closed
pwittrock opened this issue Mar 22, 2018 · 0 comments · Fixed by #66
Closed

Standardize kubebuilder codegeneration labels to have +kubebuilder: prefix #22

pwittrock opened this issue Mar 22, 2018 · 0 comments · Fixed by #66
Assignees
@Liujingfang1
Projects
SDK Sprint Planning

Comments

@pwittrock
Copy link
Contributor

Many of the codegen labels don't have this prefix

https://godoc.org/github.com/kubernetes-sigs/kubebuilder/pkg/gen/apis#example-package
https://godoc.org/github.com/kubernetes-sigs/kubebuilder/pkg/gen/controller

Must be done in a backward compatible way - add support for the new label and change the defaults created when bootstrapping.l
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Liujingfang1 Liujingfang1

Labels
None yet
Projects
No open projects
SDK Sprint Planning
  
Done - Sprint 1 (05/02/2018)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

standardize kubebuilder codegeneration labels to have +kubebuilder: prefix Liujingfang1/kubebuilder
2 participants
@pwittrock @Liujingfang1