Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kustomize from v3.8.7 to v4.4.1 and use replacements instead of vars #2503

Closed
camilamacedo86 opened this issue Feb 1, 2022 · 1 comment · Fixed by #2583
Closed

Update kustomize from v3.8.7 to v4.4.1 and use replacements instead of vars #2503

camilamacedo86 opened this issue Feb 1, 2022 · 1 comment · Fixed by #2583
Assignees
@camilamacedo86
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
go/v4

Comments

@camilamacedo86
Copy link
Member

camilamacedo86 commented Feb 1, 2022 •
edited

What do you want to happen?

Address the changes made in: #2498
Make clear that go/v4 only supports Kubectl >= 1.22.0
Make go/v4 as the default plugin

Extra Labels

No response
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 1, 2022
@camilamacedo86 camilamacedo86 added this to the go/v4 milestone Feb 1, 2022
@camilamacedo86 camilamacedo86 added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 1, 2022
@camilamacedo86 camilamacedo86 mentioned this issue Feb 1, 2022
Closed
@camilamacedo86 camilamacedo86 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 10, 2022
@camilamacedo86
Copy link
Member Author

For we change the scaffold for the syntax and features which are only valid for kustomize v4 we need to change the kustomize plugin: https://github.com/kubernetes-sigs/kubebuilder/tree/master/pkg/plugins/common/kustomize/v1

However, see that we also bump the Kustomize version on the Golang plugin : https://github.com/afritzler/kubebuilder/blob/master/pkg/plugins/golang/v3/scaffolds/init.go#L36-L37

Which is only used to build the Makefile and pin the version that should be used.

Also, this request is related to support the new mac os arch, see: #2566

This was referenced Mar 30, 2022
Closed
Merged
@camilamacedo86 camilamacedo86 self-assigned this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camilamacedo86 camilamacedo86

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
go/v4
1 participant
@camilamacedo86