-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the tools
package in favor of go 1.18 go install
#2594
Comments
/assign |
Hi @AlmogBaku, Let's create an PR to do only this change |
Since this issue depends on joelanford/go-apidiff#15 I suggest holding that /hold |
Hi @AlmogBaku, The apidiff on Kubebuilder is only used in the Ci - Github Action Also, the new tools added to the project here: 9e94fe0 shows a mistake. Why do we need to import API diff on the project at all? In this way, it does not seems depends on:
We should change that and fix it by recomming the dep from KB go.mod ( cli ). |
Right now, the Until joelanford/go-apidiff#15 will be fixed, removing it will prevent developers from running |
@AlmogBaku, I just released go-apidiff v0.4.0. Hopefully this solves the issue! |
@AlmogBaku Wanted to check with you if it's ok if I work on this - it seems like all the pieces are in place and I'm happy to start on this if you're busy! |
What do you want to happen?
Objective
Compiling the dependent binaries using a special package
tools
can be replaced withgo install
as we are doing in the generated Makefile.Solution:
tools
dirGOBIN=$(shell dirname $(GO_APIDIFF)) go install github.com/joelanford/go-apidiff@latest
Extra Labels
No response
The text was updated successfully, but these errors were encountered: