Remove the tools package in favor of go 1.18 go install

[AlmogBaku]

What do you want to happen?

Objective

Compiling the dependent binaries using a special package tools can be replaced with go install as we are doing in the generated Makefile.

Solution:

1. Remove the tools dir
2. Replace the installation of APIDiff in the Makefile with GOBIN=$(shell dirname $(GO_APIDIFF)) go install github.com/joelanford/go-apidiff@latest

Extra Labels

No response

[AlmogBaku]

/assign

[camilamacedo86]

Hi @AlmogBaku,

Let's create an PR to do only this change
In its description, the Motivation can be add support to 1.18

[AlmogBaku]

Since this issue depends on joelanford/go-apidiff#15 I suggest holding that

/hold

[camilamacedo86]

Hi @AlmogBaku,

The apidiff on Kubebuilder is only used in the Ci - Github Action
We can still using go 1.17 for its ci if the appdiff does not work with https://github.com/kubernetes-sigs/kubebuilder/pull/2561/files#diff-dd565f122600dd57c8c3c546dd80893fe3e96c09f41ef16886f908d6d0ce7b50R21

Also, the new tools added to the project here: 9e94fe0 shows a mistake.

Why do we need to import API diff on the project at all?
It is not used by the CLI so that should not be imported in the go.mod at all.

In this way, it does not seems depends on:

Since this issue depends on joelanford/go-apidiff#15 I suggest holding that

We should change that and fix it by recomming the dep from KB go.mod ( cli ).
I can indeed add to its MOTIVATION: remove from Kubebuilder CLI unnecessary and unused deps.

[AlmogBaku]

Right now, the make apidiff does work because it uses an updated version of golang.org/x/tools from our go module.

Until joelanford/go-apidiff#15 will be fixed, removing it will prevent developers from running make apidiff in local environments with go 1.18.

[joelanford]

@AlmogBaku, I just released go-apidiff v0.4.0. Hopefully this solves the issue!

[mjlshen]

@AlmogBaku Wanted to check with you if it's ok if I work on this - it seems like all the pieces are in place and I'm happy to start on this if you're busy!