Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify if go/v2 Makefile changes to support go 1.18 can works with go 1.13+ #2694

Closed
camilamacedo86 opened this issue May 19, 2022 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@camilamacedo86
Copy link
Member

What broke? What's expected?

See the PR #2486 the changes in the Makefile were also applied to the plugin go/v2. Note that the go/v2 only exists to ensure the backwards compatibility with the old layout scaffold and the default golang bumped on it is going 1.13

Also, we cannot upgrade the go/v2 to use the latest versions of the controller runtime and controller-tools deps. See that this plugin is unable to scaffold CRD API v1 and still only working with v1beta1.

Therefore shows that we should not change the Makefile of this plugin unless we can ensure that the changes performed can successfully work with go 1.13.

What is the goal of this task:

  • Check if the changes performed in the Makefile can work with go 1.13+ or not
  • If not then, we need to revert.

Reproducing this issue

No response

KubeBuilder (CLI) Version

3.4.0

PROJECT version

No response

Plugin versions

No response

Other versions

No response

Extra Labels

No response

@camilamacedo86 camilamacedo86 added the kind/bug Categorizes issue or PR as related to a bug. label May 19, 2022
@camilamacedo86
Copy link
Member Author

@camilamacedo86 camilamacedo86 changed the title go/v2 Makefile changed to support go 1.18 go/v2 Makefile changed to support go 1.18 might introduce a bug May 19, 2022
@camilamacedo86 camilamacedo86 changed the title go/v2 Makefile changed to support go 1.18 might introduce a bug Verify if go/v2 Makefile changes to support go 1.18 can works with go 1.13+ May 19, 2022
@camilamacedo86
Copy link
Member Author

Checked that we cannot #2559 (comment)
We might need to consider deprecating the go/v2 soon since we can no longer update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant