Meta - New deploy-image/v1-alpha plugin follow ups

[camilamacedo86]

What do you want to happen?

Following some tracks, we are able to check and address them as a follow-up of #2717

• - Add valid status conditions based on the fact that the deployment was successful. (doc) and example to update the status in the controller - Done in ✨deploy-image/v1alpha: add code for updating controller status when the deployment is created successfully #2816
• Add markers validations, i.e:
  For the size:

        // The following markers will use OpenAPI v3 schema to validate the value
	// More info: https://book.kubebuilder.io/reference/markers/crd-validation.html
	// +kubebuilder:validation:Minimum=1
	// +kubebuilder:validation:Maximum=3
	// +kubebuilder:validation:ExclusiveMaximum=false

Also, would be great if we can add a check for the Port when it is informed.

• - Improve controller-test to check if the deployment/pod was made
• - Be able to do checks with images in the e2e and get the PodSatus ( that might mean moving the e2e checks to GitHub action instead of using the prow ) - PR: 🌱 (deploy-image/v1-alpha) - e2e test checking if the pods are running #2795
• - For e2e: Ensure that the deployment scaffold on the controller to deploy the Operand is checked
• - Project file has to track the options used under the plugin and not under the resources. Should we not track under the resources? What happens if we create 2 apis with the plugin? Will we have the image, command and port used for both calls tracked?
• - RunAsUser needs to be a flag arg ( we should not add it by default )
• - Scaffold controller tests see here. We will test if the deployment can be done successfully. (Done : ✨deploy-image/v1-alpha: add tests for controller using ENV TEST #2792)
• - Check the project with --namespaced=false flag to create apis. Erro faced when it was used:
  : 🐛 (deploy-image/v1-alpha) : remove the namespaced option #2805
• [x ] - Add finializers. (example) - ✨deploy-image/v1-alpha: add finalizers for the Custom Resource created #2793
• [x ] - change the labels to follow the standards: Better support for generating RBAC #281
• [x ] - Scaffold the image as a new ENV VAR in the config/manager. Todo this one we will need to use the method inserCode (example) and change the controller template to looking for the ENVVAR something like (example). Done: ✨deploy-image/v1alpha: add env var for storing the image name #2817

[camilamacedo86]

/assign @NikhilSharmaWe

[camilamacedo86]

@NikhilSharmaWe I am closing this one since this part you accomplished. Now let's check the community feedback
Great work!