You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are 2 places where we must revert the sign which we missed as part of old PR #2826
{{- if not .ComponentConfig }}
args:
- --leader-elect
{{- end }}
it should be now modified to
{{- if .ComponentConfig }}
args:
- --leader-elect
{{- end }}
As of now, we are scaffolding the controller_manager_config.yaml file only when the flag --component-config is passed.
Reproducing this issue
laxmikantbhaskarpandhare@lpandhar-mac test % cat config/manager/manager.yaml
apiVersion: v1
kind: Namespace
metadata:
labels:
control-plane: controller-manager
app.kubernetes.io/name: namespace
app.kubernetes.io/instance: system
app.kubernetes.io/component: manager
app.kubernetes.io/created-by: test
app.kubernetes.io/part-of: test
app.kubernetes.io/managed-by: kustomize
name: system
---
apiVersion: apps/v1
kind: Deployment
metadata:
name: controller-manager
namespace: system
labels:
control-plane: controller-manager
app.kubernetes.io/name: deployment
app.kubernetes.io/instance: controller-manager
app.kubernetes.io/component: manager
app.kubernetes.io/created-by: test
app.kubernetes.io/part-of: test
app.kubernetes.io/managed-by: kustomize
spec:
selector:
matchLabels:
control-plane: controller-manager
replicas: 1
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
control-plane: controller-manager
spec:
securityContext:
runAsNonRoot: true
# TODO(user): For common cases that do not require escalating privileges
# it is recommended to ensure that all your Pods/Containers are restrictive.
# More info: https://kubernetes.io/docs/concepts/security/pod-security-standards/#restricted
# Please uncomment the following code if your project does NOT have to work on old Kubernetes
# versions < 1.19 or on vendors versions which do NOT support this field by default (i.e. Openshift < 4.11 ).
# seccompProfile:
# type: RuntimeDefault
containers:
- command:
- /manager
args:
- --leader-elect
image: controller:latest
name: manager
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- "ALL"
livenessProbe:
httpGet:
path: /healthz
port: 8081
initialDelaySeconds: 15
periodSeconds: 20
readinessProbe:
httpGet:
path: /readyz
port: 8081
initialDelaySeconds: 5
periodSeconds: 10
# TODO(user): Configure the resources accordingly based on the project requirements.
# More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
resources:
limits:
cpu: 500m
memory: 128Mi
requests:
cpu: 10m
memory: 64Mi
serviceAccountName: controller-manager
terminationGracePeriodSeconds: 10
It should scaffold below code only when flag is passed.
args:
- --leader-elect
KubeBuilder (CLI) Version
v3.7.0
PROJECT version
No response
Plugin versions
v2-alpha and v1
Other versions
$ go version
go version go1.19.1 darwin/amd64
sigs.k8s.io/controller-runtime v0.13.0 // for `kubebuilder alpha config-gen`
sigs.k8s.io/controller-tools v0.10.0
What broke? What's expected?
There are 2 places where we must revert the sign which we missed as part of old PR #2826
it should be now modified to
As of now, we are scaffolding the
controller_manager_config.yaml
file only when the flag--component-config
is passed.Reproducing this issue
It should scaffold below code only when flag is passed.
KubeBuilder (CLI) Version
v3.7.0
PROJECT version
No response
Plugin versions
v2-alpha and v1
Other versions
Extra Labels
No response
The text was updated successfully, but these errors were encountered: