Docs about webhook is out of date

[Duncan-tree-zhou]

What broke? What's expected?

in doc file: 《Deploying Admission Webhooks》

line #38 and line #44, the include files is no longer exists.

{{#include ./testdata/project/config/default/kustomization.yaml}}

{{#include ./testdata/project/config/crd/kustomization.yaml}}

Reproducing this issue

goto 《Deploying Admission Webhooks》

KubeBuilder (CLI) Version

master

PROJECT version

master

Plugin versions

No response

Other versions

No response

Extra Labels

No response

[camilamacedo86]

Hi @Duncan-tree-zhou,

Definitely, we should link. We should to do as it is done for v2 : https://book-v2.book.kubebuilder.io/
To achieve this goal, the PR change needs to be against book-v1 branch . Would you like to collab with this one?

[impact-maker]

@camilamacedo86 I would like to collab and make some valuable contributions.

[camilamacedo86]

Hi @impact-maker

In this case you need to push a PR against the book-v1 branch with the same content. If you have doubts please feel free to reach out in the channel.

[impact-maker]

Hi @camilamacedo86 Added the PR #3159
Kindly review it and let me know if any changes are required on my end.

[ashutosh887]

@camilamacedo86 I would like to work on this
Please consider

[ashutosh887]

@camilamacedo86 Should I start working if the above PR is not approved?

[Duncan-tree-zhou]

@ashutosh887 you can see the PR #3159, it's already closed.

[ashutosh887]

The issue is still open @Duncan-tree-zhou
I would like to work

[camilamacedo86]

Hi @Duncan-tree-zhou,

@ashutosh887 you can see the PR #3159, it's already closed.

The PR was not accepted because it was against the v1 docs, which is legacy.

If @impact-maker will not work on this one (which seems not like) then, @ashutosh887 please feel free to work on this one.

[ashutosh887]

Thanks let me try
/assign

[Sajiyah-Salat]

hello @ashutosh887 are you still working on this. If yes link the pr. I want to review the content. if not, I am interested in working on this issue. Thank you.

[camilamacedo86]

A lot of changes has been introduced regards webhooks in controller-runtime
Therefore, we need to remove the deprecations and follow up of them.
In this way, I am closing this one in favor of: #3721