Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make deploy fails inside cronjob tutorial #3249

Closed
kallyaleksiev opened this issue Feb 23, 2023 · 2 comments
Closed

make deploy fails inside cronjob tutorial #3249

kallyaleksiev opened this issue Feb 23, 2023 · 2 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@kallyaleksiev
Copy link

What broke? What's expected?

Currently, inside the code for the cronjob tutorial (in docs/book/src/cronjob-tutorial/testdata/project) if you try to deploy it to your cluster using make deploy you get an error:

lstat kubebuilder/docs/book/src/cronjob-tutorial/testdata/project/config/manager/controller_manager_config.yaml: no such file or directory"

error: no objects passed to apply
make: *** [deploy] Error 1

because the file controller_manager_config.yaml referenced in the kustomization.yaml does not exist there

this file does not seem to be needed and the entire configMapGenerator

can be deleted, at which point make deploy works

Reproducing this issue

run make deploy inside docs/book/src/cronjob-tutorial/testdata/project

KubeBuilder (CLI) Version

3.9.0

PROJECT version

No response

Plugin versions

No response

Other versions

No response

Extra Labels

/kind documentation

@kallyaleksiev kallyaleksiev added the kind/bug Categorizes issue or PR as related to a bug. label Feb 23, 2023
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 23, 2023
@xiao-jay
Copy link
Contributor

xiao-jay commented Mar 4, 2023

i agree @kallyaleksiev,i think should remove the code block below because the code does not seem to be needed and the entire configMapGenerator.I also create a project to test cronjob tutorial,found not generate configMapGenerator:

kubebuilder/docs/book/src/multiversion-tutorial/testdata/project/config/manager/kustomization.yaml

generatorOptions:
  disableNameSuffixHash: true

configMapGenerator:
- name: manager-config
  files:
  - controller_manager_config.yaml

test cronjob tutorial way

kubebuilder init --domain tutorial.kubebuilder.io --repo tutorial.kubebuilder.io/project
kubebuilder create api --group batch --version v1 --kind CronJob 

code in kubebuilder-cronjob/config/manager/kustomization.yaml

resources:
- manager.yaml
➜  manager kubebuilder version
Version: main.version{KubeBuilderVersion:"v3.9.0-48-g73e25fad-dirty", KubernetesVendor:"unknown", GitCommit:"73e25fadb93daa1e240b4dda4df7c9016ef4d3ce", BuildDate:"2023-03-04T05:50:09Z", GoOs:"darwin", GoArch:"arm64"}

@xiao-jay
Copy link
Contributor

xiao-jay commented Mar 8, 2023

May be this issue need to close ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

No branches or pull requests

4 participants