Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the current method API to build bundles and create new version to work with Options #3307

Closed
camilamacedo86 opened this issue Mar 20, 2023 · 2 comments · Fixed by #3312
Closed

Deprecate the current method API to build bundles and create new version to work with Options #3307

camilamacedo86 opened this issue Mar 20, 2023 · 2 comments · Fixed by #3312
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@camilamacedo86
Copy link
Member

camilamacedo86 commented Mar 20, 2023 •
edited

What do you want to happen?

Currently, we have the following: https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugin/bundle.go#L33-L59
Therefore, this task is for us to deprecate the func used currently in favour of something like:

func NewBundle(opts ...BundleOptions) (Bundle, error)

and new bundles could be created like:

bundle, err := NewBundle(
  WithName("name"),
  WithVersion(plugin.Version{Number: 4}),
  WithPlugins(plugins ...Plugin),
  WithDeprecationMessage("Deprecated!"),
)

requester @everettraven see: #3276 (comment)

Extra Labels

No response
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 20, 2023
@camilamacedo86 camilamacedo86 mentioned this issue Mar 20, 2023
Merged
@camilamacedo86 camilamacedo86 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 20, 2023
@NikhilSharmaWe
Copy link
Member

I would like to work on it.

@camilamacedo86
Copy link
Member Author

That is amazing news !!! Please, feel free to raise a PR for that.

@NikhilSharmaWe NikhilSharmaWe mentioned this issue Mar 23, 2023
Merged
@NikhilSharmaWe NikhilSharmaWe mentioned this issue May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
2 participants
@camilamacedo86 @NikhilSharmaWe