Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Webhook For Core Types for CR 0.15 #3393

Closed
mythi opened this issue May 8, 2023 · 2 comments · May be fixed by #3399
Closed

Update Webhook For Core Types for CR 0.15 #3393

mythi opened this issue May 8, 2023 · 2 comments · May be fixed by #3399
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.
Milestone
v3.11.0

Comments

@mythi
Copy link

mythi commented May 8, 2023

What broke? What's expected?

It looks to me that the book docs is going to get broken in CR v0.15 series. I got mine fixed by following this commit.

Submitting this issue to track the necessary doc updates.

Reproducing this issue

No response

KubeBuilder (CLI) Version

N/A

PROJECT version

No response

Plugin versions

No response

Other versions

sigs.k8s.io/controller-runtime v0.15.0-alpha.0

Extra Labels

/kind documentation
@mythi mythi added the kind/bug Categorizes issue or PR as related to a bug. label May 8, 2023
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label May 8, 2023
@camilamacedo86
Copy link
Member

Hi @mythi,

We start to working in a PR to bump the alpha version and address the breaking changes; see: #3394

Since you could sort it out accordingly, could you give us a hand and help us to fix this doc?
WDYT? Can you push a PR within the docs fixes against the master so that it would be fixed and updated in the next release?

@camilamacedo86 camilamacedo86 added this to the v3.11.0 milestone May 8, 2023
@mythi mythi mentioned this issue May 9, 2023
Open
@camilamacedo86
Copy link
Member

Done to be shipped with Kubebuilder 3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging a pull request may close this issue.

📖 update webhooks for core types to match controller-runtime v0.15 mythi/kubebuilder
3 participants
@mythi @camilamacedo86 @k8s-ci-robot