Documentation for "Watching Externally Managed Resources" No longer matches implementation

[SimonStiil]

What broke? What's expected?

Seems like there have been a few updates to the controller-runtime that have not been added in the documentation for
https://kubebuilder.io/reference/watching-resources/externally-managed

This means if you use the examples in the documentation you get compilation issues

func (r *ConfigDeploymentReconciler) findObjectsForConfigMap(configMap client.Object) []reconcile.Request {

Should now be

func (r *ConfigDeploymentReconciler) findObjectsForConfigMap(ctx context.Context, configMap client.Object) []reconcile.Request {

        Watches(
            &source.Kind{Type: &corev1.ConfigMap{}},
            handler.EnqueueRequestsFromMapFunc(r.findObjectsForConfigMap),
            builder.WithPredicates(predicate.ResourceVersionChangedPredicate{}),
        ).

Should now be

        Watches(
            &corev1.ConfigMap{},
            handler.EnqueueRequestsFromMapFunc(r.findObjectsForConfigMap),
            builder.WithPredicates(predicate.ResourceVersionChangedPredicate{}),
        ).

Reproducing this issue

Create new kubebuilder project using
KubeBuilderVersion:"3.11.1"
sigs.k8s.io/controller-runtime v0.15.0

try to implement watching externally managed resources using existing documentation
https://kubebuilder.io/reference/watching-resources/externally-managed

KubeBuilder (CLI) Version

3.11.1

PROJECT version

3

Plugin versions

- go.kubebuilder.io/v4

Other versions

go version go1.21.0 linux/amd64

sigs.k8s.io/controller-runtime v0.15.0

Extra Labels

/kind documentation

[camilamacedo86]

Hi @SimonStiil,

Please, feel free to push a PR with the fix.
Your help is more than welcome

[camilamacedo86]

For who will take this one, please just confirm that the change is required / accurate.

[ashutosh887]

Let me take this ahead @camilamacedo86

/assign

[camilamacedo86]

Hi @ashutosh887,

Are you working in this one? If so, please, feel free to ping us if you face any challenge to achieve this one. If not, please unassigned it from you so others might able to work on it.

Thank you a lot for all your contributions 🥇 and help in make kubebuilder better for the community.

[omerxx]

This is very much needed I was battling with my own code that just worked a few months back

[ashutosh887]

@camilamacedo86 @varshaprasad96
What needs to be done in this please guide a bit!!!

[vladfr]

Bumped into this, I might as well

/assign