Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Docs around creating a Webhook for Core types #3604

Closed
phenixblue opened this issue Sep 7, 2023 · 3 comments · Fixed by #3613
Closed

Update Docs around creating a Webhook for Core types #3604

phenixblue opened this issue Sep 7, 2023 · 3 comments · Fixed by #3613
Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@phenixblue
Copy link
Member

What do you want to happen?

The Example for creating an Admission Webhook for Core Types seems to be outdated. The usage of controller-runtime 0.15.0 in the go/v4 plugin have removed the InjectDecoder method, so the decoder has to be explicitly loaded when the webhook is added to the Manager.

I would like to update the documents to reflect this change.

Extra Labels

/kind documentation
@phenixblue phenixblue added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 7, 2023
@phenixblue
Copy link
Member Author

I'm happy to do a PR for this if I can get a 👍 from a project maintainer

@phenixblue phenixblue changed the title Update Docs around around creating a Webhook for Core types Update Docs around creating a Webhook for Core types Sep 9, 2023
@camilamacedo86
Copy link
Member

HI @phenixblue,

Your PR's to contribute with the project are more than welcome.
Please, feel free to propose changes in the default scaffold and/or docs to address this one.

@phenixblue phenixblue mentioned this issue Sep 11, 2023
Merged
@vaibhavkhurana2018
Copy link
Contributor

Not sure if i should open a new issue, but there is a small typo in the reference of the var. I have created a PR for the fix: #3641

Let me know if this requires a separate issue.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

📖 Update docs for using Decoder with Core Type Webhook phenixblue/kubebuilder
4 participants
@camilamacedo86 @k8s-ci-robot @phenixblue @vaibhavkhurana2018