Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference to deprecated MultiNamespacedCacheBuilder in docs #3662

Closed
buraksekili opened this issue Oct 18, 2023 · 2 comments · Fixed by #3664
Closed

Reference to deprecated MultiNamespacedCacheBuilder in docs #3662

buraksekili opened this issue Oct 18, 2023 · 2 comments · Fixed by #3664
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@buraksekili
Copy link
Contributor

What broke? What's expected?

In the Kubebuilder documentation (https://book.kubebuilder.io/cronjob-tutorial/empty-main.html#every-journey-needs-a-start-every-program-needs-a-main), there is a reference to the deprecated cache.MultiNamespacedCacheBuilder. However, as of the controller-runtime v0.15.0 release (refer to kubernetes-sigs/controller-runtime#2157 and release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0), this function is deprecated.

The documentation needs an update to replace the deprecated usage with the new refactored cache.Options for configuring namespaces in caches.

Reproducing this issue

No response

KubeBuilder (CLI) Version

3.12.0

PROJECT version

No response

Plugin versions

No response

Other versions

No response

Extra Labels

/kind documentation
@buraksekili buraksekili added the kind/bug Categorizes issue or PR as related to a bug. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 18, 2023
@camilamacedo86
Copy link
Member

camilamacedo86 commented Oct 19, 2023 •
edited
Loading

HI @buraksekili,

Thank you for raising this one.
Would you like to contribute with this one pushing a PR for us to update the docs?

@camilamacedo86 camilamacedo86 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 19, 2023
@buraksekili buraksekili mentioned this issue Oct 19, 2023
Merged
@buraksekili
Copy link
Contributor Author

Thank you @camilamacedo86, I raised #3664.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

📖 Addressing Deprecated Manager Options buraksekili/kubebuilder
3 participants
@camilamacedo86 @k8s-ci-robot @buraksekili