Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook patches has not been generated properly for projects with multi-group layout #3761

Closed
camilamacedo86 opened this issue Jan 30, 2024 · 0 comments · Fixed by #3838
Closed
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@camilamacedo86
Copy link
Member

What broke? What's expected?

I would expected be able to generate the dist/installer.yaml for projects which has multi-group layout
See that we needed to ignore it in the sample:

make generate manifests
# TODO fix the error with multigroup layout and allow it be generated
# with this one.
# Error: trouble configuring builtin PatchTransformer with config: `
# path: patches/webhook_in_sea-creatures_krakens.yaml
# `: failed to get the patch file from path(patches/webhook_in_sea-creatures_krakens.yaml): evalsymlink failure on '/Users/camiladeomacedo/go/src/sigs.k8s.io/kubebuilder/testdata/project-v4-multigroup/config/crd/patches/webhook_in_sea-creatures_krakens.yaml' : lstat go/src/sigs.k8s.io/kubebuilder/testdata/project-v4-multigroup/config/crd/patches/webhook_in_sea-creatures_krakens.yaml: no such file or directory
if [[ $project =~ v4 && ! $project =~ multigroup ]]; then
make build-installer
fi

Reproducing this issue

Just update the script to generate the samples under test data

make generate manifests
# TODO fix the error with multigroup layout and allow it be generated
# with this one.
# Error: trouble configuring builtin PatchTransformer with config: `
# path: patches/webhook_in_sea-creatures_krakens.yaml
# `: failed to get the patch file from path(patches/webhook_in_sea-creatures_krakens.yaml): evalsymlink failure on '/Users/camiladeomacedo/go/src/sigs.k8s.io/kubebuilder/testdata/project-v4-multigroup/config/crd/patches/webhook_in_sea-creatures_krakens.yaml' : lstat go/src/sigs.k8s.io/kubebuilder/testdata/project-v4-multigroup/config/crd/patches/webhook_in_sea-creatures_krakens.yaml: no such file or directory
if [[ $project =~ v4 && ! $project =~ multigroup ]]; then
make build-installer
fi
in order to allow run make build-installer for all projects which go/v4 and see that it fails as described in the comment for the multigroup layout.

KubeBuilder (CLI) Version

master

PROJECT version

No response

Plugin versions

No response

Other versions

No response

Extra Labels

No response

@camilamacedo86 camilamacedo86 added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
1 participant