-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error to scaffold conversion webhooks #3825
Comments
/assign |
From my local reproducing, the error is:
I think it is a similar issue to: So, when following https://book.kubebuilder.io/multiversion-tutorial/api-changes.html#storage-versions, adding |
This are the steps to build our tutorial https://github.com/kubernetes-sigs/kubebuilder/tree/master/docs/book/src/multiversion-tutorial sample. After add the store it still failing in the e2e test regards the tests added for the webhook.
It could be a good first issue for someone that would like to spend so effort and get something that is not so trivial and requires investigation. Help here is very welcome !!!! |
Hi @Kavinjsir You are 100% . It is the same: #1196. The problem that I was facing was with the default tests scaffold for the the controller . It was missing declare the resource properly. See; https://github.com/kubernetes-sigs/kubebuilder/actions/runs/8844368662/job/24286141139?pr=3875 I could fix this one, but the tests for the controller still failing |
What broke? What's expected?
By running the following commands we will face an issue to generate the manifests.
I would expected the scaffolds be done accurately and no issue be faced
Reproducing this issue
Please run the commands provided above. To solve this task, analyze the results and determine the ideal scaffold needed for a fix. Note that resolving this bug involves investigating and understanding the correct approach to working with webhook conversions.
Ask for help in kubebuilder and controller-runtime channels.
Also, ask for review in both channels when you be able to provide a solution
KubeBuilder (CLI) Version
master
PROJECT version
3
Plugin versions
go/v4
Other versions
No response
Extra Labels
/kind regression
The text was updated successfully, but these errors were encountered: