Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support objectSelector in webhook's code markers #3980

Closed
pmalek opened this issue Jun 12, 2024 · 2 comments
Closed

Support objectSelector in webhook's code markers #3980

pmalek opened this issue Jun 12, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pmalek
Copy link

pmalek commented Jun 12, 2024

What do you want to happen?

Webhook code markers already support several aspects of webhook configuration https://book.kubebuilder.io/reference/markers/webhook.

This issue tracks the effort of adding support for objectSelector.

Extra Labels

No response

@pmalek pmalek added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 12, 2024
@camilamacedo86
Copy link
Member

This one need to be moved to controller-tools
The markers are implemented there.

@sbueringer could you please move this one?

@pmalek
Copy link
Author

pmalek commented Jun 13, 2024

@camilamacedo86 Thanks for the pointer! Indeed that's meant to land in controller-tools and I've missed the issue that was already created for this feature:

kubernetes-sigs/controller-tools#553

I guess we can close this one and reopen that one.

To me it looks like it would boil down to extending the config: https://github.com/kubernetes-sigs/controller-tools/blob/76b24b2709ba146f7794941ac0cdcb437144f64a/pkg/webhook/parser.go#L61-L136 but we'd need to agree on the API (since the nested structure of objectSelector makes it a bit more nuanced to "get right" than other fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants