Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Custom Marker Prefix #3990

Closed
beatrausch opened this issue Jun 20, 2024 · 2 comments · Fixed by #3993
Closed

Allow Custom Marker Prefix #3990

beatrausch opened this issue Jun 20, 2024 · 2 comments · Fixed by #3993
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@beatrausch
Copy link
Contributor

beatrausch commented Jun 20, 2024

What do you want to happen?

Hi,

we are using kubebuilder as library and looking for a way to define markers with custom names like:

var (
  conversionMarker = machinery.NewMarkerWithPrefixFor("+myprefix", kustomizationFile, "conversion")
)

What do you think?

Regards,

Extra Labels

No response

@beatrausch beatrausch added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 20, 2024
@beatrausch
Copy link
Contributor Author

Hi,

I prepared the change on a branch. Just let me know if I should create a PR.

Regards

@camilamacedo86
Copy link
Member

Hi @beatrausch,

Thank you for bringing this to our attention. Your suggestion sounds interesting!
Please feel free to submit your proposed changes through a pull request so we can review them in detail.

Assuming your changes do not alter the default behavior and are well-supported by tests, I see no reason why we wouldn't accept them.

Thank you once again for your valuable contribution.

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
2 participants