From f6d54b9ffe4b3c0336c45865a0fffa0ffca8deba Mon Sep 17 00:00:00 2001 From: Eric Stroczynski Date: Mon, 9 Nov 2020 21:52:44 -0800 Subject: [PATCH] This commit adds leases.coordination.k8s.io to the leader-election-role Role under the same rule as configmaps. These permissions are required by default by controller-runtime's leader election, which uses configmapsleases as the default election type. go/v3-alpha: add leases.coordination.k8s.io to leader election RBAC --- .../internal/templates/config/rbac/leader_election_role.go | 2 ++ testdata/project-v3-addon/config/rbac/leader_election_role.yaml | 2 ++ .../project-v3-multigroup/config/rbac/leader_election_role.yaml | 2 ++ testdata/project-v3/config/rbac/leader_election_role.yaml | 2 ++ 4 files changed, 8 insertions(+) diff --git a/pkg/plugin/v3/scaffolds/internal/templates/config/rbac/leader_election_role.go b/pkg/plugin/v3/scaffolds/internal/templates/config/rbac/leader_election_role.go index 065e790a1b2..acdef4c0291 100644 --- a/pkg/plugin/v3/scaffolds/internal/templates/config/rbac/leader_election_role.go +++ b/pkg/plugin/v3/scaffolds/internal/templates/config/rbac/leader_election_role.go @@ -48,8 +48,10 @@ metadata: rules: - apiGroups: - "" + - coordination.k8s.io resources: - configmaps + - leases verbs: - get - list diff --git a/testdata/project-v3-addon/config/rbac/leader_election_role.yaml b/testdata/project-v3-addon/config/rbac/leader_election_role.yaml index 53e974910be..6334cc51c83 100644 --- a/testdata/project-v3-addon/config/rbac/leader_election_role.yaml +++ b/testdata/project-v3-addon/config/rbac/leader_election_role.yaml @@ -6,8 +6,10 @@ metadata: rules: - apiGroups: - "" + - coordination.k8s.io resources: - configmaps + - leases verbs: - get - list diff --git a/testdata/project-v3-multigroup/config/rbac/leader_election_role.yaml b/testdata/project-v3-multigroup/config/rbac/leader_election_role.yaml index 53e974910be..6334cc51c83 100644 --- a/testdata/project-v3-multigroup/config/rbac/leader_election_role.yaml +++ b/testdata/project-v3-multigroup/config/rbac/leader_election_role.yaml @@ -6,8 +6,10 @@ metadata: rules: - apiGroups: - "" + - coordination.k8s.io resources: - configmaps + - leases verbs: - get - list diff --git a/testdata/project-v3/config/rbac/leader_election_role.yaml b/testdata/project-v3/config/rbac/leader_election_role.yaml index 53e974910be..6334cc51c83 100644 --- a/testdata/project-v3/config/rbac/leader_election_role.yaml +++ b/testdata/project-v3/config/rbac/leader_election_role.yaml @@ -6,8 +6,10 @@ metadata: rules: - apiGroups: - "" + - coordination.k8s.io resources: - configmaps + - leases verbs: - get - list