-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add priorityClassName to Multus Daemonset #11305
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mosibi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Mosibi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7ce003d
to
651a7a1
Compare
/ok-to-test |
@@ -22,6 +22,7 @@ spec: | |||
tier: node | |||
app: multus | |||
spec: | |||
priorityClassName: system-node-critical |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @Mosibi
Comparing with https://github.com/k8snetworkplumbingwg/multus-cni/blob/master/deployments/multus-daemonset.yml .
It's better to use a variable rather than changing the default setting. like
multus_priority_class_name
Another idea is to create a PR for the upstream(https://github.com/k8snetworkplumbingwg/multus-cni) first, then change the kubespray. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yankay,
My first thought was also to make it a variable, but looking at all other places in the Kubespray code where a priorityClassName is set, I found that it is set static at all places. Therefore to be consistent I did the same, but if you prefer to set it like your proposal, I will change my PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best practice is to keep the default setting with upstream. If there must be some customize, we can use variable :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, then I will submit a pull request at Multus and when that one is accepted and merged, open a one over here to update it. For now I will close this one.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #11304
Special notes for your reviewer:
Does this PR introduce a user-facing change?: