Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Graceful Node Shutdown by default (k8s 1.21+) #7732

Closed
champtar opened this issue Jun 22, 2021 · 1 comment · Fixed by #7746
Closed

Enable Graceful Node Shutdown by default (k8s 1.21+) #7732

champtar opened this issue Jun 22, 2021 · 1 comment · Fixed by #7746
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@champtar
Copy link
Contributor

https://kubernetes.io/blog/2021/04/21/graceful-node-shutdown-beta/

ShutdownGracePeriod
ShutdownGracePeriodCriticalPods

What would you like to be added:
Being able to just reboot nodes, without draining first

Why is this needed:
Make everyone life easier :)

(I don't plan to work on it soon, but pretty sure every kubespray user want this feature)
@champtar champtar added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 22, 2021
@champtar champtar changed the title Enable Graceful Node Shutdown by default Enable Graceful Node Shutdown by default (k8s 1.21+) Jun 22, 2021
@cristicalin
Copy link
Contributor

I could give it a go if we don't have other volunteers, looks like a simple enough change for a lot of value.

@cristicalin cristicalin mentioned this issue Jun 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Graceful Node Shutdown for Kubernetes >= 1.21.0 simplekube-ro/kubespray
2 participants
@champtar @cristicalin