Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom flags for kube components #899

Closed
rsmitty opened this issue Jan 13, 2017 · 1 comment
Closed

Support custom flags for kube components #899

rsmitty opened this issue Jan 13, 2017 · 1 comment

Comments

@rsmitty
Copy link
Contributor

rsmitty commented Jan 13, 2017

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature Request

One thing I've started to see the need for is to apply custom flags to the kube components that may not necessarily be kargo defaults. We kind of do something similar to this with docker options, but I'd like to see it extended.

A good use case:
As we've started building lots of different, decently sized clusters, we've noticed that we are all of a sudden hitting AWS API limits all over the place. It prevents volumes from attaching, as well as non-k8s users from doing things in AWS. A bug was filed to support this, but it involved adding a new flag to designate the timing between API calls. All good, but there's really no way for me to set this at deploy time I don't think. Plus, I don't think it's a hard requirement for all AWS users who might be trying kargo, as it only surfaces at a certain scale.

I could also see this being useful as we get further along down our at-scale testing to be able to set custom kubelet pod eviction flags and stuff.

@ant31
Copy link
Contributor

ant31 commented Aug 15, 2018

fixed by #1232

@ant31 ant31 closed this as completed Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants