Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calico: add support for v3.19.1 #7630

Merged
merged 3 commits into from
May 25, 2021
Merged

Calico: add support for v3.19.1 #7630

merged 3 commits into from
May 25, 2021

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented May 20, 2021 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds Calico 3.19.1 hashes and enables the liveness probe that was added to Calico 3.19 for calico-kube-controllers.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
I modified the original PR which added 3.19.0 hashes and updated it with the 3.19.1 hashes since 3.19.1 bugfix version was just released.
Does this PR introduce a user-facing change?:

Calico: add support for Calico 3.19.1

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cristicalin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten May 20, 2021 10:43
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2021
@cristicalin cristicalin mentioned this pull request May 20, 2021
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2021
@oomichi
Copy link
Contributor

oomichi commented May 20, 2021

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2021
@cristicalin
Copy link
Contributor Author

I wold propose to hold this off as v3.19.1 was just released and personally I try to avoid .0 releases. I'll push an update to this PR with the hashes for 3.19.1.

@cristicalin cristicalin marked this pull request as draft May 22, 2021 06:19
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2021
@cristicalin cristicalin changed the title Calico: add support for v3.19.0 Calico: add support for v3.19.1 May 22, 2021
@cristicalin cristicalin marked this pull request as ready for review May 22, 2021 11:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2021
@oomichi
Copy link
Contributor

oomichi commented May 22, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2021
floryut
floryut approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for .. 2.17 😉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 858b29f into kubernetes-sigs:master May 25, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 17, 2021
@cristicalin @LuckySB
Calico: add support for v3.19.1 (kubernetes-sigs#7630)
bc668fe 
* Calico: add v3.19.1 hashes

* enable liveness probe for calico-kube-controllers

3.19.1

* Calico: drop support for v3.16.x

* Calico: promote v3.18.3 as default
notCalle added a commit to notCalle/kubespray that referenced this pull request Sep 7, 2021
@notCalle
Update calico 3.17.4 → .5
c9c0494 
Calico: add support for v3.19.1 (kubernetes-sigs#7630)

* Calico: add v3.19.1 hashes

* enable liveness probe for calico-kube-controllers

3.19.1

* Calico: drop support for v3.16.x

* Calico: promote v3.18.3 as default

Calico: upgrade 3.18 to 3.18.4 (kubernetes-sigs#7648)

Calico: add v3.20.0 hashes (kubernetes-sigs#7855)

Calico: replace version 3.19.1 with 3.19.2 and set as default (kubernetes-sigs#7867)

Bump calico version to 3.19.2 due to adding 3.20.0 earlier

Calico: replace hashes for latest 3.17 and 3.18 to the .5 minor versions (kubernetes-sigs#7924)
notCalle pushed a commit to notCalle/kubespray that referenced this pull request Sep 7, 2021
@cristicalin @notCalle
Calico: add support for v3.19.1 (kubernetes-sigs#7630)
3a62dc1 
* Calico: add v3.19.1 hashes

* enable liveness probe for calico-kube-controllers

3.19.1

* Calico: drop support for v3.16.x

* Calico: promote v3.18.3 as default
@floryut floryut mentioned this pull request Sep 8, 2021
Closed
notCalle pushed a commit to notCalle/kubespray that referenced this pull request Dec 22, 2021
@cristicalin @notCalle
Calico: add support for v3.19.1 (kubernetes-sigs#7630)
9716736 
* Calico: add v3.19.1 hashes

* enable liveness probe for calico-kube-controllers

3.19.1

* Calico: drop support for v3.16.x

* Calico: promote v3.18.3 as default
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@cristicalin @sakuraiyuta
Calico: add support for v3.19.1 (kubernetes-sigs#7630)
ad3549a 
* Calico: add v3.19.1 hashes

* enable liveness probe for calico-kube-controllers

3.19.1

* Calico: drop support for v3.16.x

* Calico: promote v3.18.3 as default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cristicalin @k8s-ci-robot @oomichi @floryut