makefile cant exists gsed on MacOS

[Vacant2333]

What happened:
i try to install kueue in local build, but it shows

and in fact i have install gsed

What you expected to happen:
i can run make
IMAGE_REGISTRY=registry.example.com/my-user make image-local-push deploy

How to reproduce it (as minimally and precisely as possible):
OS: MacOS
IMAGE_REGISTRY=registry.example.com/my-user make image-local-push deploy

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version):
• Kueue version (use git describe --tags --dirty --always):
• Cloud provider or hardware configuration:
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[Vacant2333]

do we need fix it, i can help to create a pr :)

[tenzen-y]

@Vacant2333 Thank you for creating this issue! Yes, this is actually a bug since we never set the gsed to the SED variable. So, could you open a PR?

kueue/Makefile

Lines 88 to 94 in 43e5eb8

	SED ?= $(shell command -v sed)
	ifeq ($(shell command -v gsed 2>/dev/null),)
	SED = $(shell command -v sed)
	endif
	ifeq ($(shell ${SED} --version 2>&1 | grep -q GNU; echo $$?),1)
	$(error !!! GNU sed is required. If on OS X, use 'brew install gnu-sed'.)
	endif

[Vacant2333]

@Vacant2333 Thank you for creating this issue! Yes, this is actually a bug since we never set the gsed to the SED variable. So, could you open a PR?

kueue/Makefile

Lines 88 to 94 in 43e5eb8

	SED ?= $(shell command -v sed)
	ifeq ($(shell command -v gsed 2>/dev/null),)
	SED = $(shell command -v sed)
	endif
	ifeq ($(shell ${SED} --version 2>&1 | grep -q GNU; echo $$?),1)
	$(error !!! GNU sed is required. If on OS X, use 'brew install gnu-sed'.)
	endif

yes i will do that

/assign