Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kueuectl] Use the fake time instead of real in tests #2287

Closed
mbobrovskyi opened this issue May 27, 2024 · 1 comment · Fixed by #2364
Closed

[kueuectl] Use the fake time instead of real in tests #2287

mbobrovskyi opened this issue May 27, 2024 · 1 comment · Fixed by #2364
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented May 27, 2024

What would you like to be cleaned:
Introduce the same approach as controllers like this:

reconciler.clock = testingclock.NewFakeClock(testStartTime)

Also check this.

Why is this needed:

@mbobrovskyi mbobrovskyi added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 27, 2024
@mszadkow
Copy link
Contributor

mszadkow commented Jun 3, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants