Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Topology-Aware Scheduling compatible with cohorts and preemption #3761

Open
3 tasks
Tracked by #4249
mimowo opened this issue Dec 6, 2024 · 5 comments
Open
3 tasks
Tracked by #4249
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Dec 6, 2024

What would you like to be added:

Make TAS compatible with cohorts and preemption.

Why is this needed:

Currently, TAS does not work when cohorts or preemption are used. In that case the CQ is marked as inactive (see https://github.com/kubernetes-sigs/kueue/tree/main/keps/2724-topology-aware-scheduling#alpha).

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 6, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Dec 6, 2024

cc @mwielgus @mwysokin @tenzen-y

@mimowo
Copy link
Contributor Author

mimowo commented Feb 12, 2025

Listing cleanups to do identified during #4200:

  • introduce PodSetReference to represent PodSet names for static code analysis
  • add a unit test for if len(cq.TASFlavors) == 0 { as requested in comment
  • add a unit test for if cq.TASFlavors[*tasFlvr] == nil { as requested in comment
  • attempt to commonize the structures for PodSetResources and TASPodSetRequests as requested in comment

@tenzen-y
Copy link
Member

Could you add #4200 (comment) to your list?

@mimowo
Copy link
Contributor Author

mimowo commented Feb 12, 2025

Sure, updated the list, but I think long-term it is better to manage in the refreshed spreadsheet.

@tenzen-y
Copy link
Member

spreadsheet

Thanks, SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants