Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pprof endpoint #486

Closed
1 of 3 tasks
alculquicondor opened this issue Dec 21, 2022 · 8 comments · Fixed by #978
Closed
1 of 3 tasks

Add pprof endpoint #486

alculquicondor opened this issue Dec 21, 2022 · 8 comments · Fixed by #978
Assignees
@stuton
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@alculquicondor
Copy link
Contributor

What would you like to be added:

Add an endpoint that allows to capture a profile.

Core Kuberentes components have this:
https://github.com/kubernetes/kubernetes/blob/407bd6a4afa5f7d7cb2a596dda09cacc30828f09/cmd/kube-scheduler/app/server.go#L282

Not sure if there is a way to do this via controller runtime kubernetes-sigs/controller-runtime#1779

Why is this needed:

To inform performance improvements

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.
@alculquicondor alculquicondor added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 21, 2022
@alculquicondor
Copy link
Contributor Author

There is WIP kubernetes-sigs/controller-runtime#1943

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2023
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 22, 2023
@alculquicondor
Copy link
Contributor Author

The next release of controller-runtime should include this kubernetes-sigs/controller-runtime#1943

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2023
@alculquicondor
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 12, 2023
@trasc
Copy link
Contributor

trasc commented Jul 12, 2023

It should be doable with kubernetes-sigs/controller-runtime#1779 , we just need to add support for this in the config.

@stuton
Copy link
Contributor

stuton commented Jul 12, 2023

/assign

@stuton stuton mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuton stuton

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added pprof endpoint epam/kubernetes-kueue
6 participants
@alculquicondor @stuton @k8s-ci-robot @k8s-triage-robot @trasc @tenzen-y