From ac75d4af8f827b65f16147473fc562db07e04ab1 Mon Sep 17 00:00:00 2001 From: Mengting Yan Date: Tue, 1 Jun 2021 10:19:05 -0400 Subject: [PATCH] chore: remove Kui Settings notebook --- .../plugin-client-default/src/preload.ts | 2 +- packages/core/src/main/menu.ts | 1 - .../notebooks/settings.json | 727 ------------------ .../notebooks/welcome.json | 7 - plugins/plugin-client-default/src/preload.ts | 1 - 5 files changed, 1 insertion(+), 737 deletions(-) delete mode 100644 plugins/plugin-client-common/notebooks/settings.json diff --git a/docs/example/AnimalApp/plugins/plugin-client-default/src/preload.ts b/docs/example/AnimalApp/plugins/plugin-client-default/src/preload.ts index 2eede0d081e..80eb4b56dee 100644 --- a/docs/example/AnimalApp/plugins/plugin-client-default/src/preload.ts +++ b/docs/example/AnimalApp/plugins/plugin-client-default/src/preload.ts @@ -23,7 +23,7 @@ export default async () => { /* const { notebookVFS } = await import('@kui-shell/plugin-core-support') notebookVFS.cp( undefined, - ['plugin://plugin-client-common/notebooks/welcome.json', 'plugin://plugin-client-common/notebooks/settings.json'], + ['plugin://plugin-client-common/notebooks/welcome.json'], '/kui' ) */ } diff --git a/packages/core/src/main/menu.ts b/packages/core/src/main/menu.ts index 664bbaa9d89..61f0abb25ad 100644 --- a/packages/core/src/main/menu.ts +++ b/packages/core/src/main/menu.ts @@ -207,7 +207,6 @@ export const install = (createWindow: (executeThisArgvPlease?: string[]) => void const separator: MenuItemConstructorOptions = { type: 'separator' } const submenu: MenuItemConstructorOptions[] = [ about, - notebook('Configure Kui', '/kui/settings.json'), separator, { role: 'services', submenu: [] as MenuItemConstructorOptions[] }, separator, diff --git a/plugins/plugin-client-common/notebooks/settings.json b/plugins/plugin-client-common/notebooks/settings.json deleted file mode 100644 index 61fb9561f00..00000000000 --- a/plugins/plugin-client-common/notebooks/settings.json +++ /dev/null @@ -1,727 +0,0 @@ -{ - "apiVersion": "kui-shell/v1", - "kind": "Notebook", - "metadata": { - "name": "Kui Settings", - "description": "Kui — Settings", - "preferReExecute": true - }, - "spec": { - "splits": [ - { - "uuid": "3_c57e811f-2da8-557e-a402-9f0950407675", - "blocks": [ - { - "response": { - "apiVersion": "kui-shell/v1", - "kind": "CommentaryResponse", - "props": { - "children": "# Kui Settings\nFrom this notebook, you may configure Kui. Try out some of the Kui themes on the right." - } - }, - "historyIdx": 251, - "cwd": "~/Workspace7/kui", - "command": "# # Kui Settings\\nFrom this notebook, you may configure Kui. Try out some of the Kui themes on the right.", - "startEvent": { - "route": "/#", - "command": "# # Kui Settings\\nFrom this notebook, you may configure Kui. Try out some of the Kui themes on the right.", - "evaluatorOptions": { - "usage": { - "command": "commentary", - "strict": "commentary", - "example": "commentary -f []", - "docs": "Commentary", - "optional": [ - { - "name": "--title", - "alias": "-t", - "docs": "Title for the commentary" - }, - { - "name": "--file", - "alias": "-f", - "docs": "File that contains the texts" - } - ] - }, - "outputOnly": true, - "plugin": "plugin-client-common" - }, - "execType": 0, - "execUUID": "391834fe-c312-45db-a2c6-27ab91180eec" - }, - "completeEvent": { - "execType": 0, - "command": "# # Kui Settings\\nFrom this notebook, you may configure Kui. Try out some of the Kui themes on the right.", - "argvNoOptions": ["#"], - "parsedOptions": { - "_": ["#"] - }, - "execUUID": "391834fe-c312-45db-a2c6-27ab91180eec", - "cancelled": false, - "evaluatorOptions": { - "outputOnly": true, - "plugin": "plugin-client-common" - }, - "execOptions": { - "type": 0, - "language": "en-US", - "execUUID": "391834fe-c312-45db-a2c6-27ab91180eec", - "history": 251, - "env": {} - }, - "response": { - "apiVersion": "kui-shell/v1", - "kind": "CommentaryResponse", - "props": { - "children": "# Kui Settings\nFrom this notebook, you may configure Kui. Try out some of the Kui themes on the right." - } - }, - "responseType": "ScalarResponse", - "historyIdx": 251 - }, - "isExperimental": false, - "isReplay": true, - "execUUID": "391834fe-c312-45db-a2c6-27ab91180eec", - "startTime": "2020-09-30T18:44:26.160Z", - "prefersTerminalPresentation": false, - "outputOnly": true, - "state": "valid-response" - } - ] - }, - { - "uuid": "3_0a9586b6-2f57-5d3b-9619-b5cdb6a76d53", - "blocks": [ - { - "response": { - "apiVersion": "kui-shell/v1", - "kind": "CommentaryResponse", - "props": { - "children": "If you would like to deveop your own themes, check out the source for some of our themes:\n\n\n- Carbon Themes: https://github.com/IBM/kui/tree/master/plugins/plugin-carbon-themes\n- PatternFly themes: https://github.com/IBM/kui/tree/master/plugins/plugin-patternfly4-themes\n\n- Community themes: https://github.com/IBM/kui/tree/master/plugins/plugin-core-themes" - } - }, - "historyIdx": 97, - "cwd": "~/Workspace7/kui", - "command": "# If you would like to deveop your own themes, check out the source for some of our themes:\\n\\n\\n- Carbon Themes: https://github.com/IBM/kui/tree/master/plugins/plugin-carbon-themes\\n- PatternFly themes: https://github.com/IBM/kui/tree/master/plugins/plugin-patternfly4-themes\\n\\n- Community themes: https://github.com/IBM/kui/tree/master/plugins/plugin-core-themes", - "startEvent": { - "route": "/#", - "command": "# If you would like to deveop your own themes, check out the source for some of our themes:\\n\\n\\n- Carbon Themes: https://github.com/IBM/kui/tree/master/plugins/plugin-carbon-themes\\n- PatternFly themes: https://github.com/IBM/kui/tree/master/plugins/plugin-patternfly4-themes\\n\\n- Community themes: https://github.com/IBM/kui/tree/master/plugins/plugin-core-themes", - "evaluatorOptions": { - "usage": { - "command": "commentary", - "strict": "commentary", - "example": "commentary -f []", - "docs": "Commentary", - "optional": [ - { - "name": "--title", - "alias": "-t", - "docs": "Title for the commentary" - }, - { - "name": "--file", - "alias": "-f", - "docs": "File that contains the texts" - } - ] - }, - "outputOnly": true, - "plugin": "plugin-client-common" - }, - "execType": 0, - "execUUID": "f1a0c00d-b0a1-418d-86d6-a91778aa8ee3" - }, - "completeEvent": { - "execType": 0, - "command": "# If you would like to deveop your own themes, check out the source for some of our themes:\\n\\n\\n- Carbon Themes: https://github.com/IBM/kui/tree/master/plugins/plugin-carbon-themes\\n- PatternFly themes: https://github.com/IBM/kui/tree/master/plugins/plugin-patternfly4-themes\\n\\n- Community themes: https://github.com/IBM/kui/tree/master/plugins/plugin-core-themes", - "argvNoOptions": ["#"], - "parsedOptions": { - "_": ["#"] - }, - "execUUID": "f1a0c00d-b0a1-418d-86d6-a91778aa8ee3", - "cancelled": false, - "evaluatorOptions": { - "outputOnly": true, - "plugin": "plugin-client-common" - }, - "execOptions": { - "type": 0, - "language": "en-US", - "execUUID": "f1a0c00d-b0a1-418d-86d6-a91778aa8ee3", - "history": 97, - "env": {} - }, - "response": { - "apiVersion": "kui-shell/v1", - "kind": "CommentaryResponse", - "props": { - "children": "If you would like to deveop your own themes, check out the source for some of our themes:\n\n\n- Carbon Themes: https://github.com/IBM/kui/tree/master/plugins/plugin-carbon-themes\n- PatternFly themes: https://github.com/IBM/kui/tree/master/plugins/plugin-patternfly4-themes\n\n- Community themes: https://github.com/IBM/kui/tree/master/plugins/plugin-core-themes" - } - }, - "responseType": "ScalarResponse", - "historyIdx": 97 - }, - "isExperimental": false, - "isReplay": true, - "execUUID": "f1a0c00d-b0a1-418d-86d6-a91778aa8ee3", - "startTime": "2020-09-30T18:45:24.152Z", - "prefersTerminalPresentation": false, - "outputOnly": true, - "state": "valid-response" - } - ] - }, - { - "uuid": "3_cd0d8750-9c3b-5e47-bb06-8b8fe6c85bfb", - "inverseColors": true, - "blocks": [ - { - "response": { - "apiVersion": "kui-shell/v1", - "kind": "RadioTable", - "title": "Available Themes", - "header": { - "cells": [ - "Theme", - { - "value": "Style", - "hints": "hide-with-narrow-window" - }, - { - "value": "Provider", - "hints": "hide-with-sidecar" - } - ] - }, - "body": [ - { - "nameIdx": 0, - "cells": [ - "Carbon Gray10", - { - "value": "light", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-carbon-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set \"Carbon Gray10\"" - }, - { - "nameIdx": 0, - "cells": [ - "Carbon Gray90", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-carbon-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set \"Carbon Gray90\"" - }, - { - "nameIdx": 0, - "cells": [ - "Light", - { - "value": "light", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Light" - }, - { - "nameIdx": 0, - "cells": [ - "Dark", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Dark" - }, - { - "nameIdx": 0, - "cells": [ - "Atelier", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Atelier" - }, - { - "nameIdx": 0, - "cells": [ - "Dracula", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Dracula" - }, - { - "nameIdx": 0, - "cells": [ - "Gruvbox", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Gruvbox" - }, - { - "nameIdx": 0, - "cells": [ - "Lucario", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Lucario" - }, - { - "nameIdx": 0, - "cells": [ - "Monokai", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Monokai" - }, - { - "nameIdx": 0, - "cells": [ - "Nord", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Nord" - }, - { - "nameIdx": 0, - "cells": [ - "Paraiso", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Paraiso" - }, - { - "nameIdx": 0, - "cells": [ - "Solarized", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Solarized" - }, - { - "nameIdx": 0, - "cells": [ - "tomorrow-night", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set tomorrow-night" - }, - { - "nameIdx": 0, - "cells": [ - "PatternFly4 Light", - { - "value": "light", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-patternfly4-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set \"PatternFly4 Light\"" - }, - { - "nameIdx": 0, - "cells": [ - "PatternFly4 Dark", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-patternfly4-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set \"PatternFly4 Dark\"" - } - ], - "defaultSelectedIdx": 0 - }, - "historyIdx": 249, - "cwd": "~/Workspace7/kui", - "command": "themes", - "startEvent": { - "route": "/themes", - "startTime": 1602615838837, - "command": "themes", - "evaluatorOptions": { - "usage": { - "command": "themes", - "strict": "themes", - "docs": "List available themes" - }, - "plugin": "plugin-core-support" - }, - "execType": 1, - "execUUID": "6866f2f4-e4b5-4321-a23e-745feb2bbb20", - "echo": true - }, - "completeEvent": { - "execType": 1, - "completeTime": 1602615838860, - "command": "themes", - "argvNoOptions": ["themes"], - "parsedOptions": { - "_": ["themes"] - }, - "execUUID": "6866f2f4-e4b5-4321-a23e-745feb2bbb20", - "cancelled": false, - "echo": true, - "evaluatorOptions": { - "plugin": "plugin-core-support" - }, - "execOptions": { - "echo": true, - "type": 1, - "execUUID": "6866f2f4-e4b5-4321-a23e-745feb2bbb20", - "history": 249, - "env": {} - }, - "response": { - "apiVersion": "kui-shell/v1", - "kind": "RadioTable", - "title": "Available Themes", - "header": { - "cells": [ - "Theme", - { - "value": "Style", - "hints": "hide-with-narrow-window" - }, - { - "value": "Provider", - "hints": "hide-with-sidecar" - } - ] - }, - "body": [ - { - "nameIdx": 0, - "cells": [ - "Carbon Gray10", - { - "value": "light", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-carbon-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set \"Carbon Gray10\"" - }, - { - "nameIdx": 0, - "cells": [ - "Carbon Gray90", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-carbon-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set \"Carbon Gray90\"" - }, - { - "nameIdx": 0, - "cells": [ - "Light", - { - "value": "light", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Light" - }, - { - "nameIdx": 0, - "cells": [ - "Dark", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Dark" - }, - { - "nameIdx": 0, - "cells": [ - "Atelier", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Atelier" - }, - { - "nameIdx": 0, - "cells": [ - "Dracula", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Dracula" - }, - { - "nameIdx": 0, - "cells": [ - "Gruvbox", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Gruvbox" - }, - { - "nameIdx": 0, - "cells": [ - "Lucario", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Lucario" - }, - { - "nameIdx": 0, - "cells": [ - "Monokai", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Monokai" - }, - { - "nameIdx": 0, - "cells": [ - "Nord", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Nord" - }, - { - "nameIdx": 0, - "cells": [ - "Paraiso", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Paraiso" - }, - { - "nameIdx": 0, - "cells": [ - "Solarized", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set Solarized" - }, - { - "nameIdx": 0, - "cells": [ - "tomorrow-night", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-core-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set tomorrow-night" - }, - { - "nameIdx": 0, - "cells": [ - "PatternFly4 Light", - { - "value": "light", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-patternfly4-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set \"PatternFly4 Light\"" - }, - { - "nameIdx": 0, - "cells": [ - "PatternFly4 Dark", - { - "value": "dark", - "hints": "hide-with-narrow-window" - }, - { - "value": "plugin-patternfly4-themes", - "hints": ["hide-with-sidecar", "sub-text"] - } - ], - "onSelect": "theme set \"PatternFly4 Dark\"" - } - ], - "defaultSelectedIdx": 0 - }, - "responseType": "ScalarResponse", - "historyIdx": 249 - }, - "isExperimental": false, - "isReplay": true, - "execUUID": "6866f2f4-e4b5-4321-a23e-745feb2bbb20", - "startTime": 1602615838837, - "prefersTerminalPresentation": false, - "outputOnly": false, - "state": "valid-response" - } - ] - } - ] - } -} diff --git a/plugins/plugin-client-common/notebooks/welcome.json b/plugins/plugin-client-common/notebooks/welcome.json index 0c135441f87..61135f336d3 100644 --- a/plugins/plugin-client-common/notebooks/welcome.json +++ b/plugins/plugin-client-common/notebooks/welcome.json @@ -92661,13 +92661,6 @@ "onclick": "open /kui/make-notebook.json", "attributes": [] }, - { - "name": "Kui — Settings", - "css": "", - "onclickExec": "pexec", - "onclick": "open /kui/settings.json", - "attributes": [] - }, { "name": "Kui — Welcome to Kui", "css": "", diff --git a/plugins/plugin-client-default/src/preload.ts b/plugins/plugin-client-default/src/preload.ts index c9344a5f513..1e679d3f797 100644 --- a/plugins/plugin-client-default/src/preload.ts +++ b/plugins/plugin-client-default/src/preload.ts @@ -27,7 +27,6 @@ export default async () => { undefined, [ 'plugin://plugin-client-common/notebooks/welcome.json', - 'plugin://plugin-client-common/notebooks/settings.json', 'plugin://plugin-client-common/notebooks/make-notebook.json' ], '/kui'