Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Is it possible to patch by name or matcher rather than position? #3521

Closed
mnishizawa opened this issue Feb 1, 2021 · 4 comments
Closed
Labels
area/plugin issues for plugins kind/support Categorizes issue or PR as a support question. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@mnishizawa
Copy link

In all the examples I see for referring to a value to replace with patches, the reference looks something like
path: /spec/templates/0/inputs/parameters/2/default

To me this seems like a potential issue if someone were to move the original value from one position to another. Is there a way to use the name or some other kind of identifier so the path could be independent of the position?

@Shell32-Natsu Shell32-Natsu added area/plugin issues for plugins kind/support Categorizes issue or PR as a support question. labels Feb 1, 2021
@Shell32-Natsu
Copy link
Contributor

I assume you are talking about json patch. Unfortunately this path format is defined in the json patch RFC and kustomize just follows it.

@monopole
Copy link
Contributor

monopole commented Feb 3, 2021

#3492 talks about the general idea of grabbing data from some resource/field and writing it to some other field.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2021
@natasha41575
Copy link
Contributor

Closing this issue since the replacement transformer is now implemented (#3492). This will be available in an upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin issues for plugins kind/support Categorizes issue or PR as a support question. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants