-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation kustomize.config.k8s.io/needs-hash
not working on static resources
#4833
Comments
Reproduced. (note to self: this is documented at https://kubectl.docs.kubernetes.io/guides/extending_kustomize/#generator-options) FWIW I noticed this summer that the use of this annotation with external transformers isn't well tested, and potentially also broken. I had a WIP branch started that might be a useful reference if someone wants to look into this. |
I figured out why hash suffixing stops working with merge/replace behaviour set by /assign |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
Action Item: We would need to revisit and verify the functionality of both the annotations. @yutaroyamanaka Thanks for figuring out the cause. Does this also occur in the latest (v5.0.0+) versions of kustomize? If so, could you elaborate on what the fix is. Thank you! |
@varshaprasad96 I am able to reproduce it with v5.4.2 |
/triage accepted |
@varshaprasad96 I am able to reproduce it with v5.4.2 too |
Describe the bug
Setting annotation
kustomize.config.k8s.io/needs-hash: "true"
on static resources doesn't add hash suffix to the name. Setting the annotationinternal.config.kubernetes.io/needsHashSuffix: "enabled"
instead gets the expected result.Files that can reproduce the issue
kustomization.yaml
resources.yaml
Expected output
Actual output
Kustomize version
4.5.7
The text was updated successfully, but these errors were encountered: