Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support replacing prefixes/suffixes #5722

Open
1 of 2 tasks
TheSpiritXIII opened this issue Jun 20, 2024 · 1 comment
Open
1 of 2 tasks

Support replacing prefixes/suffixes #5722

TheSpiritXIII opened this issue Jun 20, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@TheSpiritXIII
Copy link

Eschewed features

  • This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

Currently we can add prefixes or suffixes. However, we cannot replace existing ones.

Why is this needed?

A convention I've seen in manifests is that cluster-wide resources are prefixed/suffixed, usually with the namespace used in namespace-scoped resources in the same manifest. For example, you may have a Role named bar in the namespace foo and a corresponding ClusterRole for your application named foo:baz with the namespace as a suffix to prevent overlapping with other applications.

Can you accomplish the motivating task without this feature, and if so, how?

A replacement comes close but you would need multiple to match what the current nameref transformer does. For example, you not only need to edit resources names, you need to edit references on other resources, e.g. a Role's roleRef field using the same name.

What other solutions have you considered?

N/A

Anything else we should know?

No response

Feature ownership

  • I am interested in contributing this feature myself! 🎉
@TheSpiritXIII TheSpiritXIII added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 20, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 20, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants