add GitHub token to install_kustomize.sh

[vsoch]

Problem: I started to use make and make install in CI runs that used a matrix, and was seeing this issue regularly:

Github rate-limiter failed the request. Either authenticate or wait a couple of minutes.

I suspect the expected use case is manually running locally, and it would make sense to wait and try again. But for automation I definitely wanted to authenticate! So I started to look into "how to authenticate with the GitHub API" and stumbled on your script here:

kustomize/hack/install_kustomize.sh

Lines 137 to 142 in aec3500

	releases=$(curl -s "$release_url")
	if [[ $releases == *"API rate limit exceeded"* ]]; then
	echo "Github rate-limiter failed the request. Either authenticate or wait a couple of minutes."
	exit 1
	fi

But the request using curl doesn't give any opportunity to actually add a token, so there was no way to respond!

Solution: I thought it would be easy enough to check for GITHUB_TOKEN in the environment, and if present, to add it as a header. For my own workflows, when I modified the script and did this, that error (which was showing up more times than not) has gone away. So I think (assuming that others would want this in automation) this would be good to have! Here is an example use case from my workflow:

    - name: Build and Install Operator
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      run: |
        make 
        make manifests
        make kustomize

I'm a new contributor here so please let me know what else you need me to do. Thank you!

Signed-off-by: vsoch vsoch@users.noreply.github.com

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: vsoch / name: Vanessasaurus (9bb7d63)

[k8s-ci-robot]

Welcome @vsoch!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @vsoch. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[KnVerey]

/ok-to-test
/approve

Works great, thank you! Sorry for the delay.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, vsoch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KnVerey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KnVerey]

Can you please rebase? I'm not able to trigger the main test run for some reason

[vsoch]

@KnVerey rebased!

[KnVerey]

/lgtm

[vsoch]

Thank you!