-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test-go-mod unpinned #5011
Run test-go-mod unpinned #5011
Conversation
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I learned so much from this PR!
# sigs.k8s.io/kustomize/api /Users/you/src/sigs.k8s.io/kustomize/api | ||
# sigs.k8s.io/kustomize/cmd/config /Users/you/src/sigs.k8s.io/kustomize/cmd/config | ||
IFS=$'\n' | ||
modules=($(go list -m -f "{{.Path}} {{.Dir}}")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant! Thank you, @KnVerey! Your code led me to the package template docs. I was missing the double quotes!
Continues the work in #4975
Closes #4975
Note: running this version of
make test-go-mod
generates a huge diff in go.mod/go.sum files. Presumably those are reflecting all the real dependency changes that have happened since the last release, and will show up when we update the module pins during the release. In our old workflow where we kept the "unpinning" replace statements committed on master between releases, these updates would presumably have appeared across modules as we made them. This introduces some complexity for #4975, essentially unless we start committing the unpinned results (but does that make sense?). In essence, we're jumping through hoops to avoid committing the replace statements, and we might want to re-reconsider that./cc @natasha41575 @annasong20