fix breaking examples

[koba1t]

fix breaking examples in ./examples dir.
fix #4997

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[koba1t]

removed legacy patch syntax is used.

[cailyn-codes]

This is used in other examples - is it worth updating those as well?

[koba1t]

@cailynse

I think I searched and fixed other examples where the removed legacy patch was used.
Could you find other places for it was used?

[cailyn-codes]

Sorry! I misunderstood, I was thinking patchesStrategicMerge which is being used in many places

[koba1t]

Don't worry!

[koba1t]

error caused by kustomization.yaml file is missing.

[cailyn-codes]

Does this mean the example in the issue never worked?

Just saw Katrina's comment!

[KnVerey]

Are the fixes taken from the tutorial snippets? Should we update them there instead? I don't feel strongly about it, but the tutorial is telling the user to create these files, isn't it? https://github.com/kubernetes-sigs/kustomize/tree/master/examples/springboot

[koba1t]

@KnVerey

the tutorial is telling the user to create these files

That is right.
So, Do you think better for removing non-snippet files?
Creating a few files is required using commands on the tutorials step, but the files included above dirs. (ex. patch.yaml)

kustomize/examples/springboot/README.md

Lines 107 to 119 in 0fd385d

	cat <<EOF >$DEMO_HOME/patch.yaml
	apiVersion: apps/v1
	kind: Deployment
	metadata:
	name: sbdemo
	spec:
	template:
	spec:
	containers:
	- name: sbdemo
	env:
	- name: spring.profiles.active
	value: prod

[tonglil]

Please fix the examples, thanks!

[annasong20]

/lgtm

@KnVerey @cailynse The README.md tutorial works independently of kustomize build on the roots under the springboot folder. The tutorial works because it has the user create the kustomization.yaml file that's missing under base. The tutorial also has the user create the .properties and patch files from scratch, though the content of these files is based on that of the files under overlays/production.

We could, optionally, have the tutorial curl the files from the springboot folders instead of providing the snippets that @koba1t mentions if we find them repetitive. I believe only patch.yaml file has diverged from the tutorial. The tutorial instructions, however, do not contain the legacy fields because they're created using the kustomize edit commands.

[annasong20]

nit: The README.md specifies an application.properties that only has 1 line:

app.name=Kustomize Demo

Apparently the justification there is that maintenance is easier if we separate the credentials out into a separate file: https://github.com/kubernetes-sigs/kustomize/blob/master/examples/springboot/README.md?plain=1#L95-L99.

Feel free to ignore this comment. I don't think it's important, only an observation.

[annasong20]

/label tide/merge-method-squash

[natasha41575]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annasong20, koba1t, natasha41575, tonglil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment