Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update releasing workflow #5026

Merged
merged 8 commits into from
Feb 7, 2023
Merged

Update releasing workflow #5026

merged 8 commits into from
Feb 7, 2023

Conversation

KnVerey
Copy link
Contributor

@KnVerey KnVerey commented Feb 2, 2023 •
edited
Loading

  • Updates release instructions to better reflect what we actually do
  • Adds back the pinning/unpinning step (unfortunately too many commands do not work well enough with workspace mode that I think the old process is easier overall)
  • Restores the old version of test-go-mod, in light of the above (but doesn't delete the new script in case we have novel problems and want to switch to it again)
  • Makes pinning/unpinning affect ALL modules. The repo's history goes back and forth on this, and we don't know why.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2023
@KnVerey KnVerey force-pushed the update_releasing_instr branch from 1ec1042 to 4fff839 Compare February 2, 2023 16:22
natasha41575
natasha41575 reviewed Feb 2, 2023
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2023
KnVerey
KnVerey commented Feb 2, 2023
View reviewed changes
cmd/gorepomod/internal/arguments/args.go
@@ -36,7 +36,6 @@ var (
"docs",
"examples",
"hack",
"plugin",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeff specifically added this in #3910. Why? 😕

@KnVerey
Copy link
Contributor Author

KnVerey commented Feb 2, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2023
@KnVerey KnVerey changed the title Update releasing instructions Update releasing workflow Feb 2, 2023
@KnVerey
Copy link
Contributor Author

KnVerey commented Feb 2, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2023
cailyn-codes
cailyn-codes reviewed Feb 6, 2023
View reviewed changes
releasing/README.md Outdated Show resolved Hide resolved
@KnVerey @cailyn-codes
Update releasing/README.md
63c37b1 
Co-authored-by: Cailyn <cailyn.s.e@gmail.com>
natasha41575
natasha41575 reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I just have a small question, but we don't need to hold the PR for it

cmd/gorepomod/internal/repo/dotgitdata.go
@@ -126,7 +127,7 @@ func (dg *DotGitData) checkModules(modules []*protoModule) error {
}
} else {
// Do the relative path and short name make sense?
if !strings.HasSuffix(pm.PathToGoMod(), string(shortName)) {
if !strings.HasPrefix(string(shortName), "plugin/") && !strings.HasSuffix(pm.PathToGoMod(), string(shortName)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to exclude plugins here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I think this was a left over attempt to fix the problem that in the end was caused by one plugin having an invalid module name. I'll revert it in the unpinning PR.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit a090cea into kubernetes-sigs:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@cailyn-codes cailyn-codes cailyn-codes left review comments

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KnVerey @k8s-ci-robot @cailyn-codes @natasha41575