Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golangci-lint to v1.51.2 #5085

Merged
merged 4 commits into from
Mar 10, 2023
Merged

update golangci-lint to v1.51.2 #5085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
736e166
update golangci-lint to 1.51.2
koba1t Mar 8, 2023
39264a7
use enable-all on golangci-lint
koba1t Mar 8, 2023
7d150ce
Revert "use enable-all on golangci-lint"
koba1t Mar 10, 2023
e1094da
skip unrelevant lint
koba1t Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ linters:
- interfacebloat
- loggercheck
- reassign
- ginkgolinter
- gocheckcompilerdirectives
- musttag

linters-settings:
dupl:
Expand Down
2 changes: 1 addition & 1 deletion Makefile-tools.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright 2022 The Kubernetes Authors.
# SPDX-License-Identifier: Apache-2.0

GOLANGCI_LINT_VERSION=v1.50.1
GOLANGCI_LINT_VERSION=v1.51.2

MYGOBIN = $(shell go env GOBIN)
ifeq ($(MYGOBIN),)
Expand Down
1 change: 1 addition & 0 deletions api/internal/localizer/builtinplugins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ func (lbp *localizeBuiltinPlugins) localizeAll(node *yaml.RNode) error {
// We rely on the build command to throw errors for nodes in
// built-in plugins that are sequences when expected to be scalar,
// and vice versa.
//nolint: exhaustive
switch node.YNode().Kind {
case yaml.SequenceNode:
return errors.Wrap(node.VisitElements(lbp.localizeScalar))
Expand Down