-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeepCopy for ResourceMeta and ObjectMeta #5145
Add DeepCopy for ResourceMeta and ObjectMeta #5145
Conversation
Welcome @SimonTheLeg! |
Hi @SimonTheLeg. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @natasha41575 as we previously talked about this topic in a kpt PR |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, SimonTheLeg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Some context for other reviewers: this PR makes it easier to use tooling such as kubebuilder and controller-gen when embedding kyaml types into CRDs. |
This change adds the DeepCopy functionality for ResourceMeta and ObjectMeta, as these contain complex types.
This allows users of the kyaml package to embed these types into their own types and enable DeepCopy. Here is an example:
Because Kubernetes upstream ObjectMeta and TypeMeta are quite stable, I went with the assumption that ResourceMeta will also stay rather stable. As a result I decided to manually create the DeepCopy functions. I think this makes it a lot easier than setting up a complicated CI which calls controller-gen to generate the DeepCopy.